Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

10920: Sku => Entity_id relations are fetched inefficiently when inserting attributes values during product import. #11719

Merged
merged 2 commits into from
Nov 9, 2017

Conversation

nmalevanec
Copy link
Contributor

@nmalevanec nmalevanec commented Oct 25, 2017

Fix for "Sku => Entity_id relations are fetched inefficiently when inserting attributes values during product import"

Description

Replace fetchOne() in loop with getting product ids from protected property _oldSku, which has all necessary information when attributes begin to save, in Magento/CatalogImportExport/Model/Import/Product::_saveProductAttributes() to increase efficiency during product import.

Fixed Issues (if relevant)

  1. Sku => Entity_id relations are fetched inefficiently when inserting attributes values during product import #10920: Issue title Sku => Entity_id relations are fetched inefficiently when inserting attributes values during product import

Manual testing scenarios

  1. Run import of products from sample csv.
  2. Check imported products in admin. Make sure all information was correctly imported from catalog_product.csv(sample csv).
  3. Compare performance during import with 2.2-develop branch. For instance you can use : http://devdocs.magento.com/guides/v2.0/config-guide/db-profiler/db-profiler.html . Number of queries and overall time execution should decrease compare to 2.2-develop.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

…hen inserting attributes values during product import.
…hen inserting attributes values during product import.
@nmalevanec nmalevanec changed the title MAGETWO-10920: Sku => Entity_id relations are fetched inefficiently when inserting attributes values during product import. 10920: Sku => Entity_id relations are fetched inefficiently when inserting attributes values during product import. Oct 27, 2017
@dmanners dmanners self-assigned this Nov 6, 2017
@dmanners dmanners added this to the November 2017 milestone Nov 6, 2017
@okorshenko okorshenko merged commit ec0210e into magento:2.2-develop Nov 9, 2017
okorshenko pushed a commit that referenced this pull request Nov 9, 2017
…ently when inserting attributes values during product import. #11719
@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Nov 9, 2017
@nmalevanec nmalevanec deleted the MAGETWO-10920 branch August 21, 2018 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants