Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

M2.2.4 missing meta title tag and doesn't show product name if meta title is empty #15501

Closed
hirale opened this issue May 24, 2018 · 6 comments
Closed

M2.2.4 missing meta title tag and doesn't show product name if meta title is empty #15501

hirale opened this issue May 24, 2018 · 6 comments
Assignees
@phoenix128
Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Progress: PR Created Indicates that Pull Request has been created to fix issue Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@hirale
Copy link

hirale commented May 24, 2018

Preconditions

  1. Magento 2.2.4
  2. PHP 7.1

Steps to reproduce

  1. fresh install via composer
  2. install sample data

Expected result

  1. should show product name as brower title and should have meta title tag in html source

Actual result

  1. [Screenshot, logs]
    snipaste20180524_181222
    snipaste20180524_181212
    snipaste20180524_175409
  1. If only exist Product name, in frontend will display nothing.
  2. If meta title exists, in frontend <title> tag will get value of it. but missing tag.
@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label May 24, 2018
@akosglue
Copy link

@Naturegreen have you got a fix for it?

@phoenix128 phoenix128 self-assigned this May 26, 2018
@phoenix128 phoenix128 added Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels May 26, 2018
phoenix128 added a commit to phoenix128/magento2 that referenced this issue May 26, 2018
@phoenix128
FIX for issue magento#15501 - M2.2.4 missing meta title tag and doesn…
0a38b84 
…'t show product name if meta title is empty
@phoenix128 phoenix128 mentioned this issue May 26, 2018
Merged
4 tasks
@ishakhsuvarov ishakhsuvarov added the Progress: PR Created Indicates that Pull Request has been created to fix issue label May 26, 2018
@ghost
Copy link

ghost commented May 28, 2018

Hi Guys, same issue here, do you have an update on this? thanks!

@ghost
Copy link

ghost commented May 29, 2018

Hey guys, it's possible to apply an override of this? I saw that there're multiple protected and private methods and that's not usual when we made overrides, plugins cannot be used for this purpose (only public methods can be modified with Magento 2 plugins) can anyone share an alternative method to apply this until a new Magento version comes out?

thanks.

@xuanserfe
Copy link

Hi There,
I've applied the fix proposed in the commit #15532 and is not working with the following configuration:
dev/front_end_developmennt_workflow/type -> client_side_compilation
I don't have a fix for this by now, but please review this.
Regards

@sidolov
Copy link
Contributor

sidolov commented Jun 22, 2018

Hi @Naturegreen. Thank you for your report.
The issue has been fixed in #15532 by @phoenix128 in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.6 release.

@sidolov sidolov added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Jun 22, 2018
@sidolov sidolov closed this as completed Jun 22, 2018
magento-engcom-team added a commit that referenced this issue Jun 22, 2018
@magento-engcom-team
ENGCOM-1911: FIX for issue #15501 - M2.2.4 missing meta title tag and…
34c6de2 
… doesn't show… #15532

 - Merge Pull Request #15532 from phoenix128/magento2:issue-15501-missing-meta-title-tag
 - Merged commits:
   1. 0a38b84
   2. 85ac3be
   3. 432cf00
   4. 1413d65
magento-engcom-team pushed a commit that referenced this issue Jun 22, 2018
@VladimirZaets
ENGCOM-1911: FIX for issue #15501 - M2.2.4 missing meta title tag and…
b5e21b6 
… doesn't show… #15532
@gelanivishal gelanivishal mentioned this issue Jul 7, 2018
Closed
4 tasks
@nmalevanec nmalevanec mentioned this issue Aug 23, 2018
Merged
4 tasks
@magento-engcom-team
Copy link
Contributor

Hi @Naturegreen. Thank you for your report.
The issue has been fixed in #17771 by @nmalevanec in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.0 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Sep 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phoenix128 phoenix128

Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Progress: PR Created Indicates that Pull Request has been created to fix issue Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@ishakhsuvarov @phoenix128 @sidolov @akosglue @hirale @magento-engcom-team @xuanserfe