Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First PDF download / export after login #15510

Closed
magento2dev opened this issue May 25, 2018 · 3 comments
Closed

First PDF download / export after login #15510

magento2dev opened this issue May 25, 2018 · 3 comments
Assignees
@phoenix128
Labels
Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Progress: PR Created Indicates that Pull Request has been created to fix issue Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release up for grabs

Comments

@magento2dev
Copy link

Preconditions

  1. Magento 2.2.3

Steps to reproduce

  1. Log in with an admin user who does not have the permissions Other Settings -> Notifications -> *
  2. Right after login try to download any PDF or export data

Expected result

  1. Download of generated file

Actual result

  1. Redirect to Admin Dashboard

If you are trying a second time to download PDF or export it will work. The issue is based on isFirstPageAfterLogin(), when user does not have the Notifications permission, it's never set to false.
@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label May 25, 2018
@phoenix128 phoenix128 changed the title First PSD download / export after login First PDF download / export after login May 26, 2018
@phoenix128 phoenix128 self-assigned this May 26, 2018
@phoenix128 phoenix128 added Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels May 26, 2018
phoenix128 added a commit to phoenix128/magento2 that referenced this issue May 26, 2018
@phoenix128
FIX fo rissue magento#15510 - First PDF download / export after login
59e03c1
@phoenix128 phoenix128 mentioned this issue May 26, 2018
Merged
4 tasks
@ishakhsuvarov ishakhsuvarov added the Progress: PR Created Indicates that Pull Request has been created to fix issue label May 26, 2018
This was referenced Jun 4, 2018
Merged
Merged
@VladimirZaets
Copy link
Contributor

Hi @anthony-jullien. Thank you for your report.
The issue has been fixed in #15539 by @phoenix128 in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.6 release.

@VladimirZaets VladimirZaets added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Jun 6, 2018
@VladimirZaets
Copy link
Contributor

Hi @anthony-jullien. Thank you for your report.
The issue has been fixed in #15767 by @sanjay-wagento in 2.1-develop branch
Related commit(s):

The fix will be available with the upcoming 2.1.15 release.

@VladimirZaets VladimirZaets added the Fixed in 2.1.x The issue has been fixed in 2.1 release line label Jun 6, 2018
magento-engcom-team added a commit that referenced this issue Jun 6, 2018
@magento-engcom-team
ENGCOM-1858: FIX fo rissue #15510 - First PDF download / export after…
7950e1b 
… login #15539

 - Merge Pull Request #15539 from phoenix128/magento2:issue-15510-first-download
 - Merged commits:
   1. 59e03c1
magento-engcom-team pushed a commit that referenced this issue Jun 6, 2018
ENGCOM-1858: FIX fo rissue #15510 - First PDF download / export after…
ed03001 
… login #15539
magento-engcom-team added a commit that referenced this issue Jun 6, 2018
@magento-engcom-team
ENGCOM-1859: [Backport] FIX fo rissue #15510 - First PDF download / e…
71fb481 
…xport after login #15767

 - Merge Pull Request #15767 from sanjay-wagento/magento2:2.1-develop-PR-port-15539
 - Merged commits:
   1. 8e43c07
magento-engcom-team pushed a commit that referenced this issue Jun 6, 2018
ENGCOM-1859: [Backport] FIX fo rissue #15510 - First PDF download / e…
8b91a72 
…xport after login #15767
@magento-engcom-team
Copy link
Contributor

Hi @anthony-jullien. Thank you for your report.
The issue has been fixed in #15766 by @sanjay-wagento in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.0 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Jun 12, 2018
magento-engcom-team added a commit that referenced this issue Jun 12, 2018
@magento-engcom-team
ENGCOM-1831: [Forwardport] FIX fo rissue #15510 - First PDF download …
483c1bf 
…/ export after login #15766

 - Merge Pull Request #15766 from sanjay-wagento/magento2:2.3-develop-PR-port-15539
 - Merged commits:
   1. d58ab5f
magento-engcom-team pushed a commit that referenced this issue Jun 12, 2018
ENGCOM-1831: [Forwardport] FIX fo rissue #15510 - First PDF download …
c9fc88f 
…/ export after login #15766
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phoenix128 phoenix128

Labels
Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Progress: PR Created Indicates that Pull Request has been created to fix issue Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release up for grabs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@ishakhsuvarov @magento2dev @VladimirZaets @phoenix128 @magento-engcom-team