Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styling <select> by changing less variables in Luma theme doesn't work as expected #15608

Closed
denistrator opened this issue May 30, 2018 · 7 comments
Assignees
Labels
Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed

Comments

@denistrator
Copy link

Preconditions

  1. FE theme inherited from Luma

Steps to reproduce

  1. In Custom/theme/web/css/source/_theme.less set less variables:
    @select__background: rgba(255, 255, 255, 0.15);
    @select__border: 2px dashed blue;
    @select__height: 50px;
    @select__padding: 15px 40px 15px 15px;
    @select__background-clip: border-box;
  2. Compile less

Expected result

Have "select" elements with the styles you set in _theme.less

Actual result

"select" elements have different styles

What causes the issue

web/css/source/_forms.less overrides some "select" styles defined with "@select__" variables
screenshot_287

Solution

Remove styles for background, border, height, padding-right from web/css/source/_forms.less and set these styles in _theme.less

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label May 30, 2018
@hitesh-wagento
Copy link
Contributor

I am working on this

@hitesh-wagento hitesh-wagento self-assigned this Jun 4, 2018
@DanielRuf
Copy link
Contributor

Shouldn't be this in _extend.less?

@hitesh-wagento
Copy link
Contributor

hitesh-wagento commented Jun 4, 2018

@DanielRuf No it's not working in _extend.less. We should move change from web/css/source/_forms.less to web/css/source/_theme.less

image

@sidolov
Copy link
Contributor

sidolov commented Jun 6, 2018

Hi @denistrator. Thank you for your report.
The issue has been fixed in #15794 by @hitesh-wagento in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.0 release.

@denistrator
Copy link
Author

denistrator commented Jun 6, 2018

Hi @sidolov. Can you also have a look at #14999, please? It's a very small issue I opened (it has a PR #15000)

@VladimirZaets
Copy link
Contributor

Hi @denistrator. Thank you for your report.
The issue has been fixed in #15734 by @hitesh-wagento in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.6 release.

@VladimirZaets VladimirZaets added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Jun 6, 2018
@VladimirZaets
Copy link
Contributor

Hi @denistrator. Thank you for your report.
The issue has been fixed in #15796 by @hitesh-wagento in 2.1-develop branch
Related commit(s):

The fix will be available with the upcoming 2.1.15 release.

@VladimirZaets VladimirZaets added the Fixed in 2.1.x The issue has been fixed in 2.1 release line label Jun 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed
Projects
None yet
Development

No branches or pull requests

6 participants