Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

product_type attribute contains incorrect value in mass import export csv after creating custom type_id attribute. actual type_id value in database gets change with newly created attribute type_id. #19891

Closed
surabhisrivastava09 opened this issue Dec 20, 2018 · 8 comments
Assignees
Labels
Component: Catalog Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@surabhisrivastava09
Copy link
Member

Preconditions (*)

  1. magento 2.2.4
  2. PHP 7.0.15

Steps to reproduce (*)

  1. Create dropdown type product attribute with attribute code "type_id" and assign the product attribute to attribute set.
  2. Create new product using that attribute and save it.
  3. Export the product.
  4. Import using the same csv.

Expected result (*)

  1. Magento shouldn't allows to create attribute with attribute code type_id.
  2. product_type column in csv should not contain the custom type_id attribute value.
  3. If it is allows to create attribute but it shouldn't allows to create product.

Actual result (*)

  1. Magento allows to create the attribute with attribute code type_id.
  2. product_type column in csv contains the custom type_id attribute value.
  3. After creating product using type_id attribute , price & quantity fields value become 0 or null.

http://i.imgur.com/UTDCehu.png
http://i.imgur.com/43j5o1x.png
i.imgur.com/7PGBpXi.png

@magento-engcom-team
Copy link
Contributor

Hi @Surabhi-Cedcoss. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me $VERSION instance

where $VERSION is version tags (starting from 2.2.0+) or develop branches (for example: 2.3-develop).
For more details, please, review the Magento Contributor Assistant documentation.

@Surabhi-Cedcoss do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Dec 20, 2018
@GovindaSharma GovindaSharma self-assigned this Dec 20, 2018
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Dec 20, 2018

Hi @GovindaSharma. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@GovindaSharma GovindaSharma added Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Component: Catalog labels Dec 20, 2018
@GovindaSharma
Copy link
Contributor

@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @GovindaSharma. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @GovindaSharma, here is your Magento instance.
Admin access: https://i-19891-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@GovindaSharma GovindaSharma added Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Dec 20, 2018
@magento-engcom-team
Copy link
Contributor

@GovindaSharma Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-97253, MAGETWO-97254 were created

@magento-engcom-team
Copy link
Contributor

Hi @Surabhi-Cedcoss. Thank you for your report.
The issue has been fixed in #20115 by @GovindaSharma in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.2 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Feb 13, 2019
magento-engcom-team added a commit that referenced this issue Feb 13, 2019
 - Merge Pull Request #20115 from GovindaSharma/magento2:2.3-DevelopPR5
 - Merged commits:
   1. b9d13e6
amol2jcommerce pushed a commit to amol2jcommerce/magento2 that referenced this issue Feb 13, 2019
Fixed issue magento#19891 added check of attribute type_id
@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Feb 22, 2019
@magento-engcom-team
Copy link
Contributor

Hi @Surabhi-Cedcoss. Thank you for your report.
The issue has been fixed in #21208 by @amol2jcommerce in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.9 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Catalog Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

No branches or pull requests

3 participants