Magento 2.2.6 Searching for product with dash doesn't work #21059

Luuk-Meijer · 2019-02-08T09:03:55Z

Preconditions (*)

Magento 2 version 2.2.6

Steps to reproduce (*)

In "vendor/magento/module-catalog-search/etc/search_request.xml" change

<query xsi:type="boolQuery" name="quick_search_container" boost="1">
    <queryReference clause="should" ref="search" />
    <queryReference clause="must" ref="category"/>
    <queryReference clause="must" ref="price"/>
    <queryReference clause="must" ref="visibility"/>
</query>

to

<query xsi:type="boolQuery" name="quick_search_container" boost="1">
    <queryReference clause="must" ref="search" />
    <queryReference clause="must" ref="category"/>
    <queryReference clause="must" ref="price"/>
    <queryReference clause="must" ref="visibility"/>
</query>

So that the search query "blue boot" only shows products with both the words.
2. Add a product in the back-end with a name with a dash (-) in the name.
For instance "Lakboot Black Mat New A-327 N118" in my case
3. On the frontend search for that product.
So with my example you would search for "A-327".
4. Now when you have the search clause for must nothing is going to show up.

Expected result (*)

You would expect the product to show up

Actual result (*)

There are no results found

magento-engcom-team · 2019-02-08T09:03:57Z

Hi @DeLuuk. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

Summary of the issue
Information on your environment
Steps to reproduce
Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@DeLuuk do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

yes
no

Luuk-Meijer · 2019-02-08T09:08:10Z

@magento-engcom-team I can't reproduce this on a vanilla instance since the "vendor/magento/module-catalog-search/etc/search_request.xml" needs to be changed first.

I know that that would maybe mean it isn't a vanilla bug but in my opinion editing that clause should be possible and should work.

magento-engcom-team · 2019-02-08T09:12:07Z

Hi @engcom-backlog-nazar. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
Details
If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
4. Verify that the issue is reproducible on 2.3-develop branch
Details
- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

5. Verify that the issue is reproducible on 2.2-develop branch.
Details
- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x
Next steps are available in case you are a member of Community Maintainers.
6. Add label Issue: Confirmed once verification is complete.
7. Make sure that automatic system confirms that report has been added to the backlog.

ghost · 2019-02-08T09:14:17Z

HI @DeLuuk thank you for you report, this will fixed by this pr -> #20727

ghost · 2019-02-08T09:17:44Z

@DeLuuk

After changing any of these options, rebuild your FULLTEXT indexes for the change to take effect. For example, to make two-character words searchable, you could put the following lines in an option file:

[mysqld]
innodb_ft_min_token_size=2
ft_min_word_len=2

https://dev.mysql.com/doc/refman/8.0/en/fulltext-fine-tuning.html

Luuk-Meijer · 2019-02-08T09:25:08Z

@magento-engcom-team thanks for linking other issue but Im still having trouble.

I want to be able to search for "A-327" not just "A-".
I haven't edited my option file yet, don't even know where that file is, but even if I do I dont think that would fix my problem.

Like I said in the reproduce steps, this isn't just a vanilla Magento 2.2.6 enviroment.

I edited "vendor/magento/module-catalog-search/etc/search_request.xml". If I reverse does changes then it works. But I want to keep those changes since I dont want my search query to work with OR but with AND.

And those changes aren't made in pr -> #20727.

So if I can I'm reopening this since it isn't fixed.

Luuk-Meijer · 2019-02-08T09:25:46Z

@engcom-backlog-nazar can this issue be opened again?

ghost · 2019-02-08T09:33:17Z

@DeLuuk i'm will recheck, this must be environmental issue

ghost · 2019-02-08T09:34:29Z

@DeLuuk yes this is non-issue after i apply changes from pr and set -> #21059 (comment)

Luuk-Meijer · 2019-02-08T09:35:12Z

@engcom-backlog-nazar but now change:
"vendor/magento/module-catalog-search/etc/search_request.xml" change

<query xsi:type="boolQuery" name="quick_search_container" boost="1">
    <queryReference clause="should" ref="search" />
    <queryReference clause="must" ref="category"/>
    <queryReference clause="must" ref="price"/>
    <queryReference clause="must" ref="visibility"/>
</query>

to

<query xsi:type="boolQuery" name="quick_search_container" boost="1">
    <queryReference clause="must" ref="search" />
    <queryReference clause="must" ref="category"/>
    <queryReference clause="must" ref="price"/>
    <queryReference clause="must" ref="visibility"/>
</query>

And see what happens then

ghost · 2019-02-08T09:35:33Z

@DeLuuk yes i'm set this :)

Luuk-Meijer · 2019-02-08T09:39:22Z

@engcom-backlog-nazar oke in that case Im gone try editing that option file.

Where can I find that option file? The url you linked is just for MySql specific, not Magento specific.

I mean I can't put that in a .htaccess or something?

ghost · 2019-02-08T09:40:14Z

@DeLuuk you on ubuntu ? this is in mysqld sudo nano /etc/mysql/mysql.conf.d/mysqld.cnf
find the [mysqld] section add following

[mysqld]
innodb_ft_min_token_size=2
ft_min_word_len=2

then restart mysql server

Luuk-Meijer · 2019-02-08T09:48:07Z

@engcom-backlog-nazar is that server wide? I have my test shop on the same server as the live shops. So I want to be sure that I dont break anything

ghost · 2019-02-08T09:52:11Z

@DeLuuk this will affect for all websites if they use same server. try to test this locally.

Luuk-Meijer · 2019-02-08T09:57:04Z

@engcom-backlog-nazar I have CentOS not Ubuntu.

Also I know Im asking a lot of questions and this isn't support but how can I test it locally.. 😅

ghost · 2019-02-08T10:01:35Z

@DeLuuk in centOS this file in -> /etc/my.cnf add after [mysqld]

innodb_ft_min_token_size=2
ft_min_word_len=2

Luuk-Meijer · 2019-02-08T10:07:02Z

Oke @engcom-backlog-nazar Im gone have to believe you on your word then since Im not adding this for the live just yet!!

Im gone push it live next tuesday morning so I'm hoping this is gone work!!

Thanks for answering all my questions!

ghost · 2019-02-08T10:09:04Z

@DeLuuk your welcome, But also add changes from reference Pull Request.

Luuk-Meijer · 2019-02-08T10:10:10Z

@engcom-backlog-nazar Yes I realise that thanks!! Will do 😄

Luuk-Meijer · 2019-02-13T09:03:25Z

@engcom-backlog-nazar Oke I just changed the files to match this commit and added this to /etc/my.cnf:

innodb_ft_min_token_size=2
ft_min_word_len=2

But I still can't search for "A-327".
(And yes I restarted mysql, upgraded, compiled, redeployed, reindexed and flushed the cache)

ghost · 2019-02-13T09:08:16Z

@DeLuuk wrong commit you simply need add "-" to this ->
const SPECIAL_CHARACTERS = '-+~/\\<>\'":*$#@()!,.?=%&^';`

https://github.com/Nazar65/magento2/blob/7539e8e6829197467b59e417e317d38ea39a005b/lib/internal/Magento/Framework/Search/Adapter/Mysql/Query/Builder/Match.php#L29

Luuk-Meijer · 2019-02-13T09:13:51Z

@engcom-backlog-nazar the reason I did the other commit is because that commit was already in my Magento 2.2.6 environment.
But I just removed the other commit just incase. But that also doesn't work.

ghost · 2019-02-13T09:15:42Z

@DeLuuk ok thanks, give me 5 minutes i'm will recheck, because i'm migrated to archlinux :)

ghost · 2019-02-13T09:21:24Z

@DeLuuk

Luuk-Meijer · 2019-02-13T09:24:32Z

@engcom-backlog-nazar I see. I noticed that thats a 2.3dev environment. Does this also work on a 2.2.6 environment?

ghost · 2019-02-13T09:26:11Z

@DeLuuk hm.. try change to <queryReference clause="should" ref="search" />

Luuk-Meijer · 2019-02-13T09:28:04Z

@engcom-backlog-nazar yeah but that's the whole point! That would indeed work.

But then if customers search for "Blue boots" they get all the products with "Blue" or "boots". My client wants to only show products that have "Blue" and "boots". That way the search results go from 300 to 20.

ghost · 2019-02-13T09:35:46Z

@DeLuuk yeap, i'm found the problem this works for skus like this 41-315 but does not for sku like yours A-315

Luuk-Meijer · 2019-02-13T09:38:21Z

Oke @engcom-backlog-nazar but now what?

Can this be fixed or is it already fixed somewhere? Or?

ghost · 2019-02-13T09:41:00Z

@DeLuuk i will recheck it deeper this may be related to minimal search words, but anyway i'm will reopen this if have no solution and this caused by magento

ghost · 2019-02-13T10:17:50Z

@DeLuuk The core problem in Mysql because they have not ability to set min_search_world to =1 , your select is AGAINST ('+a* +315*' IN BOOLEAN MODE)) where +a have 1 lenth word that mysql does not find product but if you have 2 words that it works.

Luuk-Meijer · 2019-02-13T10:28:03Z

@engcom-backlog-nazar oke so you're saying that for it to work you need to be able to search for 1 character?
Damn... That works great for "A-327", but if 10 people search for just "A" that could be bad..

What do you suggest? Is there a fix for this?

ghost · 2019-02-13T14:06:41Z

@DeLuuk https://lists.mysql.com/mysql/174354

ghost · 2019-02-13T14:10:42Z

@DeLuuk this is Mysql bug https://bugs.mysql.com/bug.php?id=2095

ghost · 2019-02-13T14:20:14Z

@DeLuuk here is another workaround. It was recently added to the manual:
"
Modify a character set file: This requires no recompilation. The true_word_char() macro uses a “character type” table to distinguish letters and numbers from other characters. . You can edit the contents in one of the character set XML files to specify that '-' is a “letter.” Then use the given character set for your FULLTEXT indexes.
"

Luuk-Meijer · 2019-02-15T11:32:11Z

@engcom-backlog-nazar Oke and I'm guessing you have to use the true_word_char() macro when you sent the string to mysql?
If so, do you know the file that that's located in? I had searched that file for a long time and couldn't find it before..

But again thanks for helping me so far!

Puru2016 · 2019-04-18T07:32:51Z

Any solution in Magento 2.2.6 ? I am still facing this issue

Luuk-Meijer · 2019-04-18T08:02:38Z

@Puru2016 in the end I didn't get it working with standard Magento 2 unfortunately.

I did however install this extension that made it work.

https://mirasvit.com/magento-2-extensions/sphinx-search-ultimate.html

toan-tam · 2020-06-17T13:35:27Z

@Puru2016 in the end I didn't get it working with standard Magento 2 unfortunately.

I did however install this extension that made it work.

https://mirasvit.com/magento-2-extensions/sphinx-search-ultimate.html

Thanks for pointing it out. Mirasvit extension works for me as well.

magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Feb 8, 2019

ghost self-assigned this Feb 8, 2019

ghost closed this as completed Feb 8, 2019

ghost reopened this Feb 13, 2019

ghost added Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Component: CatalogSearch Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Feb 13, 2019

ghost closed this as completed Feb 13, 2019

Nazar65 mentioned this issue Jul 9, 2019

Quick search by SKU not working properly #9988

Closed

This issue was closed.

Magento 2.2.6 Searching for product with dash doesn't work #21059

Magento 2.2.6 Searching for product with dash doesn't work #21059

Comments

Luuk-Meijer commented Feb 8, 2019

Preconditions (*)

Steps to reproduce (*)

Expected result (*)

Actual result (*)

magento-engcom-team commented Feb 8, 2019

Luuk-Meijer commented Feb 8, 2019

magento-engcom-team commented Feb 8, 2019

ghost commented Feb 8, 2019

ghost commented Feb 8, 2019

Luuk-Meijer commented Feb 8, 2019

Luuk-Meijer commented Feb 8, 2019

ghost commented Feb 8, 2019

ghost commented Feb 8, 2019

Luuk-Meijer commented Feb 8, 2019

ghost commented Feb 8, 2019 • edited by ghost Loading

Luuk-Meijer commented Feb 8, 2019

ghost commented Feb 8, 2019 • edited by ghost Loading

Luuk-Meijer commented Feb 8, 2019

ghost commented Feb 8, 2019

Luuk-Meijer commented Feb 8, 2019

ghost commented Feb 8, 2019

Luuk-Meijer commented Feb 8, 2019

ghost commented Feb 8, 2019

Luuk-Meijer commented Feb 8, 2019

Luuk-Meijer commented Feb 13, 2019

ghost commented Feb 13, 2019

Luuk-Meijer commented Feb 13, 2019 • edited Loading

ghost commented Feb 13, 2019

ghost commented Feb 13, 2019

Luuk-Meijer commented Feb 13, 2019

ghost commented Feb 13, 2019

Luuk-Meijer commented Feb 13, 2019

ghost commented Feb 13, 2019

Luuk-Meijer commented Feb 13, 2019

ghost commented Feb 13, 2019 • edited by ghost Loading

ghost commented Feb 13, 2019 • edited by ghost Loading

Luuk-Meijer commented Feb 13, 2019

ghost commented Feb 13, 2019

ghost commented Feb 13, 2019

ghost commented Feb 13, 2019

Luuk-Meijer commented Feb 15, 2019

Puru2016 commented Apr 18, 2019

Luuk-Meijer commented Apr 18, 2019

toan-tam commented Jun 17, 2020

ghost commented Feb 8, 2019 •

edited by ghost

Loading

ghost commented Feb 8, 2019 •

edited by ghost

Loading

Luuk-Meijer commented Feb 13, 2019 •

edited

Loading

ghost commented Feb 13, 2019 •

edited by ghost

Loading

ghost commented Feb 13, 2019 •

edited by ghost

Loading