Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As low as displays incorrect pricing on category page, tax appears to be added twice #21383

Closed
devchris79 opened this issue Feb 21, 2019 · 19 comments
Assignees
Labels
Area: Frontend Component: Catalog Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@devchris79
Copy link

Preconditions (*)

  1. Magento 2.2.6

Steps to reproduce (*)

  1. Add a new item with some tier pricing
  2. Set Stores->Configuration->Sales->Tax->Price Display Settings->Display Product Prices In Catalog to "Including and Excluding Tax".

Expected result (*)

  1. As low as price to be correct, even if displayed without tax only.

Actual result (*)

  1. As low as price appears to have tax added twice, this does not happen if Excluding Tax is used as display option.
  2. Please see example below, price is correct on product page but not in the category view.
    ds2824a
    ds2824b
@magento-engcom-team
Copy link
Contributor

Hi @devchris79. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@devchris79 do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Feb 21, 2019
@krishprakash krishprakash self-assigned this Feb 21, 2019
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Feb 21, 2019

Hi @krishprakash. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • Next steps are available in case you are a member of Community Maintainers.

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@krishprakash krishprakash added Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Component: Catalog Area: Frontend labels Feb 21, 2019
@krishprakash
Copy link

@magento-engcom-team give me 2.2-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @krishprakash. Thank you for your request. I'm working on Magento 2.2-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @krishprakash, here is your Magento instance.
Admin access: https://i-21383-2-2-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@AltayAkkus
Copy link

@magento-engcom-team Give me 2.2.6-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @AltayAkkus. Thank you for your request. I'm working on Magento 2.2.6-develop instance for you

@AltayAkkus
Copy link

@magento-engcom-team Give me 2.2-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @AltayAkkus. Thank you for your request. I'm working on Magento 2.2-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @AltayAkkus, here is your Magento instance.
Admin access: https://i-21383-2-2-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@devchris79
Copy link
Author

The fix suggested by Jitheesh appears to work for me 👍

@rogyar rogyar added Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Feb 23, 2019
@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Feb 23, 2019
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @rogyar
Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-98410 were created

Issue Available: @rogyar, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@magento-engcom-team
Copy link
Contributor

Hi @devchris79. Thank you for your report.
The issue has been fixed in #21395 by @Jitheesh in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.2 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Mar 1, 2019
magento-engcom-team added a commit that referenced this issue Mar 1, 2019
…ax appears to be added twice #21383 #21395

 - Merge Pull Request #21395 from Jitheesh/magento2:feature/tier-min-price-21383
 - Merged commits:
   1. c9fff89
magento-engcom-team added a commit that referenced this issue Mar 1, 2019
…ax appears to be added twice #21383 #21395

 - Merge Pull Request #21395 from Jitheesh/magento2:feature/tier-min-price-21383
 - Merged commits:
   1. c9fff89
   2. 70f2599
magento-engcom-team pushed a commit that referenced this issue Mar 1, 2019
eduard13 pushed a commit to eduard13/magento2 that referenced this issue Mar 1, 2019
@rogyar rogyar added the Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release label Mar 4, 2019
@magento-engcom-team
Copy link
Contributor

Hi @devchris79. Thank you for your report.
The issue has been fixed in #21527 by @eduard13 in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.9 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Mar 6, 2019
magento-engcom-team added a commit that referenced this issue Mar 6, 2019
…ory page, tax appears to be added twice #21383 #21527

 - Merge Pull Request #21527 from eduard13/magento2:2.2-develop-PR-port-21395
 - Merged commits:
   1. eaad776
   2. aa7fee5
magento-engcom-team pushed a commit that referenced this issue Mar 6, 2019
@devchris79
Copy link
Author

I have upgraded to 2.3.1 and the issue appears in that version too.

@Jitheesh
Copy link
Contributor

"The fix will be available with the upcoming 2.3.2 release"

@devchris79
Copy link
Author

Hi @Jitheesh,

Do you know where the line in 2.3.1 is that needs changing?
/vendor/magento/module-catalog/Pricing/Price/MinimalTierPriceCalculator.php just looks like function prototypes.

Thanks in advance if you are able to help.

@Jitheesh
Copy link
Contributor

Jitheesh commented Apr 1, 2019

Hi @devchris79

You can refer changes from this commit c9fff89

@devchris79
Copy link
Author

Ah, was looking in MinimalPriceCalculatorInterface.php, too many similar sounding files :-)
Thanks Jitheesh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend Component: Catalog Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

No branches or pull requests

6 participants