Cart is emptied when enter is pressed after changing product quantity

[wojtekn]

Preconditions

1. Latest 2.3-develop

Steps to reproduce

1. Add any product to cart
2. Navigate to the cart
3. Un-hide "Clear Shopping Cart" button which is hidden in Luma by default by running this in browser console:
   jQuery("#empty_cart_button").show();
4. Change item quantity in the input
5. Press "Enter"

Expected result

1. Page is reloaded and item quantity is changed

Actual result

1. Cart is cleared

This happens because there are two submit buttons in the cart form, and when enter is pressed, the first one is executed. First one is "Clear Shopping Cart", so cart is cleared instead of updated. The simplest fix is to change order of those elements in source code.

[magento-engcom-team]

Hi @wojtekn. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@wojtekn do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

• yes
• no

[magento-engcom-team]

Hi @engcom-backlog-nazar. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Verify that the issue is reproducible on 2.2-develop branch.

  Details

  - Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

• Next steps are available in case you are a member of Community Maintainers.

• 6. Add label Issue: Confirmed once verification is complete.

• 7. Make sure that automatic system confirms that report has been added to the backlog.

[wojtekn]

@magento-engcom-team give me 2.3-develop instance

[magento-engcom-team]

Hi @wojtekn. Thank you for your request. I'm working on Magento 2.3-develop instance for you

[magento-engcom-team]

Hi @wojtekn, here is your Magento instance.
Admin access: https://i-21499-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

[wojtekn]

I reproduced the issue on provided instance.

[magento-engcom-team]

✅ Confirmed by @rogyar
Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-98486 were created

Issue Available: @rogyar, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

[lfluvisotto]

@wojtekn , @rogyar

Have a look at this PR #21509, it doesn't need to change the button's order/position

[lfluvisotto]

@magento-engcom-team give me 2.2-develop instance

[magento-engcom-team]

Hi @lfluvisotto. Thank you for your request. I'm working on Magento 2.2-develop instance for you

[magento-engcom-team]

Hi @lfluvisotto, here is your Magento instance.
Admin access: https://i-21499-2-2-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

[wojtekn]

@lfluvisotto it's still better to adjust their position to have primary button first in the DOM, also, if issue can be clearly fixed by using better HTML, we don't need to add JS hacks.

[magento-engcom-team]

Hi @lfluvisotto. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

• 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 2. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 3. Verify that the issue is reproducible on 2.2-develop branch.

  Details

  - Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

• 4. If the issue is not relevant or is not reproducible any more, feel free to close it.

[lfluvisotto]

@wojtekn

It isn't a JS hack it's a JS fix, since magento 1 and now with magento 2 that button to clear/empty the cart comes before the update cart button.

For example: your fix is about changing the position of buttons, but if the user want to keep in their layout/template without CSS hack, the clear/empty cart button button before update cart button, your fix it's going to fail.

cc @VladimirZaets

[magento-engcom-team]

Hi @magento-engcom-team. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

• 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 2. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 3. Verify that the issue is reproducible on 2.2-develop branch.

  Details

  - Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

• 4. If the issue is not relevant or is not reproducible any more, feel free to close it.

[magento-engcom-team]

Hi @wojtekn. Thank you for your report.
The issue has been fixed in #21509 by @lfluvisotto in 2.3-develop branch
Related commit(s):

• 539766f41049e8e86490b2861de8c98227236198
• fd3344be60488b5f59c4fcffb1080c2a7689ad81

The fix will be available with the upcoming 2.3.2 release.

[magento-engcom-team]

Hi @wojtekn. Thank you for your report.
The issue has been fixed in #21512 by @lfluvisotto in 2.2-develop branch
Related commit(s):

• 5a736409eef6c7841f4a6fc8f3a7a8a8affd2a32
• f4a83f6344c6fc11400fcd0e8d206ec206c9f37c
• 5d0245df8119614ad52768f7d1b1bbfd35c4c626

The fix will be available with the upcoming 2.2.9 release.

[magento-engcom-team]

Hi @wojtekn. Thank you for your report.
The issue has been fixed in #24499 by @edenduong in 2.3-develop branch
Related commit(s):

• 7005d99ae4af1f3ffdf35ba8370c4295c0bfbfe6
• 5847d9f64dad423d83bf0c742d810783ca213639

The fix will be available with the upcoming 2.3.4 release.