-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incorrect empty cart button behavior #21500
Fix incorrect empty cart button behavior #21500
Conversation
…update product quantity
Hi @wojtekn. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
|
Hi @wojtekn. Thank you for your request. I'm working on Magento instance for you |
Hi @wojtekn, here is your new Magento instance. |
I can't reproduce problem anymore on provided test instance. |
@magento-engcom-team give me test instance |
Hi @rogyar. Thank you for your request. I'm working on Magento instance for you |
Hi @rogyar, here is your new Magento instance. |
Hi @rogyar, thank you for the review. |
Hi @wojtekn, thank you for your contribution! |
Description
PR changes order of cart form submit elements to have Update Shopping Cart first in the DOM, to make sure it is used as submit button when Enter key is pressed. There is also change to the theme styling to adjust Clear Shopping Cart position after changing buttons order.
Fixed Issues
Manual testing scenarios
jQuery("#empty_cart_button").show();
Expected result is to have product quantity updated.
Contribution checklist