Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Asynchronous email sending for the sales entities which were created with disabled email sending #21786

Closed
serhiyzhovnir opened this issue Mar 16, 2019 · 4 comments
Closed

Asynchronous email sending for the sales entities which were created with disabled email sending #21786

serhiyzhovnir opened this issue Mar 16, 2019 · 4 comments
Assignees
@serhiyzhovnir
Labels
Component: AsynchronousOperations Component: Email Component: Sales Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@serhiyzhovnir
Copy link

Preconditions (*)

  1. Magento 2.3, Magento 2.2
  2. Enabled CRON
  3. enabled sales_email/general/async_sending config

Steps to reproduce (*)

  1. Disable email sending config for Invoice, Creditmemo, Shipment entities (Stores->Configuration->Sales->Sales Emails)
  2. Create Invoice, Creditmemo, Shipment via admin panel
  3. Enable email sending config for Invoice, Creditmemo, Shipment entities
  4. Wait for CRON or trigger it manually via bin/magento cron:run command

Expected result (*)

  1. The emails for the sales entities which were created with disabled email sending do not send via asynchronous email sending after enabling the email sending config for the sales entities.

Actual result (*)

  1. The emails for the sales entities which were created with disabled email sending send via asynchronous email sending after enabling email sending config for the sales entities.
@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Mar 16, 2019
@Leandry Leandry self-assigned this Mar 16, 2019
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Mar 16, 2019 •
edited by Leandry
Loading

Hi @Leandry. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • Next steps are available in case you are a member of Community Maintainers.

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

serhiyzhovnir pushed a commit to serhiyzhovnir/magento2 that referenced this issue Mar 16, 2019
magento#21786 Fix asynchronous email sending for the sales entities w…
8ed9266 
…hich were created with disabled email sending
@Leandry Leandry added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed and removed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Mar 16, 2019
@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Mar 16, 2019
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @Leandry
Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-98743, MAGETWO-98744 were created

Issue Available: @Leandry, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

serhiyzhovnir pushed a commit to serhiyzhovnir/magento2 that referenced this issue Mar 16, 2019
magento#21786 Remove unused param docs
3ebdbff
@serhiyzhovnir serhiyzhovnir mentioned this issue Mar 16, 2019
Merged
4 tasks
@ghost ghost assigned serhiyzhovnir Mar 27, 2019
serhiyzhovnir pushed a commit to serhiyzhovnir/magento2 that referenced this issue Apr 2, 2019
magento#21786 Fix the issue with asynchronous email sending for the s…
3751e4b 
…ales entities
@serhiyzhovnir serhiyzhovnir mentioned this issue Apr 2, 2019
Merged
4 tasks
@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Apr 16, 2019
@magento-engcom-team
Copy link
Contributor

Hi @serhiyzhovnir. Thank you for your report.
The issue has been fixed in #21788 by @serhiyzhovnir in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.2 release.

magento-engcom-team added a commit that referenced this issue Apr 16, 2019
@magento-engcom-team
ENGCOM-4512: #21786 Fixed asynchronous email sending for the sales en…
1c0d274 
…tities which were created with disabled email sending #21788

 - Merge Pull Request #21788 from serhiyzhovnir/magento2:issue-21786-fix-asynchronous-email-sending-for-the-sales-entities-which-were-created-with-disabled-email-sending
 - Merged commits:
   1. 8ed9266
   2. 3ebdbff
   3. 17cd172
magento-engcom-team added a commit that referenced this issue Apr 16, 2019
@magento-engcom-team
ENGCOM-4512: #21786 Fixed asynchronous email sending for the sales en…
78e98e4 
…tities which were created with disabled email sending #21788

 - Merge Pull Request #21788 from serhiyzhovnir/magento2:issue-21786-fix-asynchronous-email-sending-for-the-sales-entities-which-were-created-with-disabled-email-sending
 - Merged commits:
   1. 8ed9266
   2. 3ebdbff
   3. 17cd172
   4. f36dbc9
   5. 1a297e8
magento-engcom-team pushed a commit that referenced this issue Apr 16, 2019
@sidolov
ENGCOM-4512: #21786 Fixed asynchronous email sending for the sales en…
84826f9 
…tities which were created with disabled email sending #21788
@magento-engcom-team
Copy link
Contributor

Hi @serhiyzhovnir. Thank you for your report.
The issue has been fixed in #22108 by @serhiyzhovnir in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.9 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Apr 25, 2019
magento-engcom-team added a commit that referenced this issue Apr 25, 2019
@magento-engcom-team
ENGCOM-4824: [Backport] #21786 Fix the issue with asynchronous email …
dda7186 
…sending for the sales entities #22108

 - Merge Pull Request #22108 from serhiyzhovnir/magento2:2.2-develop-PR-port-21788
 - Merged commits:
   1. 3751e4b
magento-engcom-team pushed a commit that referenced this issue Apr 25, 2019
@sivaschenko
ENGCOM-4824: [Backport] #21786 Fix the issue with asynchronous email …
226d0d9 
…sending for the sales entities #22108
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@serhiyzhovnir serhiyzhovnir

Labels
Component: AsynchronousOperations Component: Email Component: Sales Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Leandry @serhiyzhovnir @magento-engcom-team