Refactor Mage_Rating_Model_Resource_Rating_Collection

[ihor-sviziev]

Class Mage_Rating_Model_Resource_Rating_Collection has method addStoresToCollection, that has code like this:

if (!$this->_isCollectionLoaded) {
    return $this;
}

I think it need be refactored like in Mage_Review_Model_Resource_Review_Collection::addStoreData:

public function addStoreData()
{
    $this->_addStoreDataFlag = true;
    return $this;
}

and Mage_Review_Model_Resource_Review_Collection::_addStoreDataFlag:

protected function _addStoreData()
{
    $adapter = $this->getConnection();

    $reviewsIds = $this->getColumnValues('review_id');
    $storesToReviews = array();
    if (count($reviewsIds)>0) {
        $inCond = $adapter->prepareSqlCondition('review_id', array('in' => $reviewsIds));
        $select = $adapter->select()
            ->from($this->_reviewStoreTable)
            ->where($inCond);
        $result = $adapter->fetchAll($select);
        foreach ($result as $row) {
            if (!isset($storesToReviews[$row['review_id']])) {
                $storesToReviews[$row['review_id']] = array();
            }
            $storesToReviews[$row['review_id']][] = $row['store_id'];
        }
    }

    foreach ($this as $item) {
        if (isset($storesToReviews[$item->getId()])) {
            $item->setStores($storesToReviews[$item->getId()]);
        } else {
            $item->setStores(array());
        }
    }
}

In load():

if ($this->_addStoreDataFlag) {
    $this->_addStoreData();
}

[ihor-sviziev]

The code is available in the version dev56 recently released.