Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CURL Json POST #3489

Closed
Grohotun opened this issue Feb 19, 2016 · 7 comments
Closed

CURL Json POST #3489

Grohotun opened this issue Feb 19, 2016 · 7 comments
Labels
Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Progress: needs update

Comments

@Grohotun
Copy link
Contributor

Using \Magento\Framework\HTTP\Client\Curl doesn't support json posts, because it used only

$this->curlOption(CURLOPT_POSTFIELDS, http_build_query($params));

But need:

CURLOPT_POSTFIELDS, json_encode($params))

@vkorotun vkorotun removed the PS label Aug 4, 2016
@veloraven
Copy link
Contributor

@Grohotun thank you for reporting.
Is this issue still actual?
Please close it if it is not.
Please specified Magento version if it is.

@voleye
Copy link

voleye commented Sep 28, 2016

We are closing this issue because it hasn’t been updated in more than two weeks. If you can still reproduce this issue, please create a new GitHub issue report.

@voleye voleye closed this as completed Sep 28, 2016
mmansoor-magento pushed a commit that referenced this issue Feb 8, 2017
 - Merge Pull Request #8373 from mygento/magento2:develop
mmansoor-magento pushed a commit that referenced this issue Feb 8, 2017
 - added type string to parameter $param in order to support sending JSON or XML requests
@okorshenko
Copy link
Contributor

@Grohotun this issue is resolved now by your PR: #8373 Thank you!

@magento-engcom-team
Copy link
Contributor

Hi @Grohotun. Thank you for your report.
The issue has been fixed in #14151 by @simpleadm in 2.1-develop branch
Related commit(s):

The fix will be available with the upcoming 2.1.14 release.

@magento-engcom-team magento-engcom-team added Fixed in 2.1.x The issue has been fixed in 2.1 release line Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed labels Mar 17, 2018
@Grohotun
Copy link
Contributor Author

Grohotun commented Mar 18, 2018

@magento-engcom-team will be this issue also updated on 2.1+ versions?

@magento-engcom-team
Copy link
Contributor

Hi @Grohotun. Thank you for your report.
The issue has been fixed in #14481 by @simpleadm in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.0 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Apr 2, 2018
@sidolov
Copy link
Contributor

sidolov commented Apr 5, 2018

Hi @Grohotun. Thank you for your report.
The issue has been fixed in #14169 by @simpleadm in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.0 release.

magento-engcom-team pushed a commit that referenced this issue Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Progress: needs update
Projects
None yet
Development

No branches or pull requests

8 participants