Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag to silence dot output from setup:static-content:deploy #3692

Closed
erikhansen opened this issue Mar 8, 2016 · 12 comments
Closed

Add flag to silence dot output from setup:static-content:deploy #3692

erikhansen opened this issue Mar 8, 2016 · 12 comments

Comments

@erikhansen
Copy link
Contributor

erikhansen commented Mar 8, 2016

I'm using Capistrano to deploy Magento 2 to production and stage environments. As a part of the deployment process, I'm running the bin/magento setup:static-content:deploy command. However since Capistrano streams all output to screen, I see this:

capistrano

So I've resorted to passing in the -q flag to silence all output: bin/magento setup:static-content:deploy -q. However this doesn't allow me to see progress as each theme is compiled. I'd like to see a flag added like --no-progress that would result in output like this:

php -f bin/magento -- setup:static-content:deploy --no-progress
Requested languages: en_US
=== frontend -> Magento/blank -> en_US ===
=== frontend -> Magento/luma -> en_US ===
=== frontend -> Customvendor/customtheme -> en_US ===
@erikhansen
Copy link
Contributor Author

@antonkril This feature request is a similar request to the one in issue #3038, so I'm pinging you so you're aware of it.

@hshar7
Copy link
Contributor

hshar7 commented Mar 8, 2016

Hi @erikhansen thanks for reporting this, how is this problem not because of Capistrano? Because if I run this command on my machine I get dots next to each other instead of each one on a new line.
Also it is possible to do something like this (with the addition of new line character for you of course):
Image

@vrann
Copy link
Contributor

vrann commented Mar 9, 2016

@erikhansen Thanks for the suggestions. As far as it relates primarily to Capistrano, would you mind to create a Pull Request with the needed changes?

@erikhansen
Copy link
Contributor Author

@hshar7 Thanks for your suggestion of piping output through tr to remove the dots. I tried that and it doesn't work.

@vrann I could see this being useful for a broader audience than just Capistrano users. Unfortunately I don't have time to create a PR for it now. If you don't think this is likely to get added to the Magento 2 roadmap, then feel free to close this task.

davidalger pushed a commit to davidalger/capistrano-magento2 that referenced this issue Apr 27, 2016
This is to workaround the way capistrano handles buffering, as was noted in magento/magento2#3692. The workaround here (I believe) will require core-utils be installed on the remote server. Eventually I'd like to see the use of stdbuf removed, in favor of a --no-progress flag on the cli tool.
@davidalger
Copy link
Member

@erikhansen A workaround is to use stdbuf from core-utils to prevent the shell from buffering the output of tr as seen in the above tagged commit. This results in the dots being stripped, but the normal output passing through normally to the CLI as it is output.

Ideally, there would still be an option to create a more friendly output format for deployment tools such as capistrano, but this solves the problem for capistrano in the meantime.

@hostep
Copy link
Contributor

hostep commented May 18, 2016

This is a duplicate of #2848 btw :)

@piotrekkaminski
Copy link
Contributor

--no-progress flag proposed in #2848 seems better name

This is low priority issue, if anyone can provide PR great but otherwise will not be done.

@erikhansen
Copy link
Contributor Author

@piotrekkaminski If PR #4294 is merged, it will satisfy the objective of this task. Since PR #4294 is actively being discussed and only needs a little more work in order to be merged in, I am going to close this task in hopes that #4294 will be merged soon.

@hostep
Copy link
Contributor

hostep commented Jun 20, 2016

@erikhansen: care to explain how #4294 will help with silencing the progress output of the command? Because I don't see a flag for that? Maybe best to reopen this issue, so one day it might still get implemented.

@erikhansen
Copy link
Contributor Author

@hostep You're correct. For some reason I was getting this issue confused with #3038. Re-opening this issue.

@piotrekkaminski I agree that a --no-progress flag would be better. Updating my issue description accordingly.

@erikhansen erikhansen reopened this Jun 20, 2016
@ClaudiuCreanga
Copy link

ClaudiuCreanga commented Jul 13, 2016

Just to be aware that is not an issue just with capistrano, but it is affecting a lot of deployment tools (i.e deploybot and others). A PR would be nice because it is hard to debug your deployment with all those dots.

@piotrekkaminski
Copy link
Contributor

Thank you for your submission.

We recently made some changes to the way we process GitHub submissions to more quickly identify and respond to core code issues.

Feature Requests and Improvements should now be submitted to the new Magento 2 Feature Requests and Improvements forum (see details here).

We are closing this GitHub ticket and have moved your request to the new forum.

magento-team pushed a commit that referenced this issue Mar 26, 2019
[TSG] Backporting for 2.1 (pr63) (2.1.17)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants