Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magento\Search\Helper\getSuggestUrl() not used in search template #6802

Closed
schmengler opened this issue Sep 29, 2016 · 3 comments
Closed

Magento\Search\Helper\getSuggestUrl() not used in search template #6802

schmengler opened this issue Sep 29, 2016 · 3 comments
Assignees
Labels
bug report Component: Search Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@schmengler
Copy link
Contributor

schmengler commented Sep 29, 2016

Preconditions

  1. Magento 2.1.1

Steps to reproduce

  1. Create a plugin for Magento\Search\Helper\getSuggestUrl() to add custom autosuggest feature
  2. Type something in the search box

Expected result

  1. the custom URL should be used

Actual result

  1. the default "search/ajax/suggest" URL is used

The problem is that getSuggestUrl() is never used anywhere in the core code. Instead, magento/module-search/view/frontend/templates/form.mini.phtml contains the hard coded route:

echo $block->getUrl('search/ajax/suggest', ['_secure' => $block->getRequest()->isSecure()]);

This makes it hard to implement a useful autosuggest feature, especially since it might very well be a URL that's not going to a Magento controller.

schmengler added a commit to integer-net/solr-magento2 that referenced this issue Oct 6, 2016
This does not have effect yet in Magento 2.1 - see magento/magento2#6802
@magento-engcom-team magento-engcom-team added 2.1.x bug report Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Component: Search labels Sep 11, 2017
@magento-engcom-team magento-engcom-team added the Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed label Oct 11, 2017
@magento-engcom-team
Copy link
Contributor

@schmengler, thank you for your report.
We've created internal ticket(s) MAGETWO-81592 to track progress on the issue.

@magento-engcom-team magento-engcom-team added 2.2.x Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Oct 11, 2017
@nmalevanec nmalevanec self-assigned this Oct 25, 2017
@okorshenko
Copy link
Contributor

The issue has been fixed in 2.2-develop branch. Will be available with 2.2.2 release

@okorshenko okorshenko added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Nov 9, 2017
@magento-team
Copy link
Contributor

Hi @schmengler. Thank you for your report.
The issue has been fixed in magento-engcom/magento2ce#1287 by @magento-engcom-team in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming patch release.

@magento-team magento-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Jan 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Component: Search Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

No branches or pull requests

6 participants