Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add-to-cart checkbox still visible when $canItemsAddToCart = false #6891

Closed
thdoan opened this issue Oct 6, 2016 · 7 comments
Closed

Add-to-cart checkbox still visible when $canItemsAddToCart = false #6891

thdoan opened this issue Oct 6, 2016 · 7 comments
Labels
bug report Component: Catalog Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@thdoan
Copy link

thdoan commented Oct 6, 2016 •
edited
Loading

Preconditions

  1. Magento version: 2.1.1

Steps to reproduce

  1. Edit vendor\magento\module-catalog\view\frontend\templates\product\list\items.phtml
  2. Set all instances of $canItemsAddToCart to false
  3. Go to a product page (e.g., /caesar-warm-up-pant.html)

Expected result

  1. The add-to-cart checkboxes in Related Products should not be visible.

Actual result

  1. The add-to-cart checkboxes in Related Products are still visible:

image
@thdoan
Copy link
Author

thdoan commented Oct 6, 2016 •
edited
Loading

Proposed fix:

Line 206, change to:

<?php if ($canItemsAddToCart && !$_item->isComposite() && $_item->isSaleable() && $type == 'related'): ?>

@sevos1984
Copy link
Contributor

Thanks for reporting. Internal ticket MAGETWO-59540

@sevos1984 sevos1984 added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Oct 10, 2016
@magento-engcom-team magento-engcom-team added 2.1.x Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development bug report Component: Catalog Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed labels Sep 11, 2017
@magento-engcom-team magento-engcom-team added the Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed label Oct 6, 2017
@magento-engcom-team
Copy link
Contributor

@thdoan, thank you for your report.
We've created internal ticket(s) MAGETWO-59540 to track progress on the issue.

@magento-engcom-team magento-engcom-team added 2.2.x Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Oct 11, 2017
This was referenced Oct 21, 2017
Merged
Merged
@magento-team
Copy link
Contributor

Internal ticket to track issue progress: MAGETWO-82755

@okorshenko
Copy link
Contributor

The issue has been fixed and delivered to 2.2-develop branch. Will be available with 2.2.2 release

@magento-team
Copy link
Contributor

Internal ticket to track issue progress: MAGETWO-82756

@magento-team
Copy link
Contributor

Hi @thdoan. Thank you for your report.
The issue has been fixed in magento-engcom/magento2ce#1284 by @magento-engcom-team in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming patch release.

@magento-team magento-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Jan 26, 2018
@okorshenko okorshenko added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Jan 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug report Component: Catalog Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@magento-team @veloraven @thdoan @okorshenko @sevos1984 @magento-engcom-team