Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR#6891_22 Add-to-cart checkbox still visible when = false #11610

Merged
merged 1 commit into from
Oct 27, 2017

Conversation

mrodespin
Copy link
Contributor

@mrodespin mrodespin commented Oct 21, 2017

If the related products list has the purchase disabled the checkbox for adding products wont disappeared as expected.

Description

The variable $canItemsAddToCart was not taking in care for disabling the product add to cart checkbox object in this file

vendor\magento\module-catalog\view\frontend\templates\product\list\items.phtml

Fixed Issues (if relevant)

  1. Add-to-cart checkbox still visible when $canItemsAddToCart = false #6891: Add-to-cart checkbox still visible when $canItemsAddToCart = false

Manual testing scenarios

Edit vendor\magento\module-catalog\view\frontend\templates\product\list\items.phtml
Set all instances of $canItemsAddToCart to false
Go to a product page (e.g., /caesar-warm-up-pant.html)
The add-to-cart checkboxes in Related Products should not be visible.

Related PRs

#11611

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@okorshenko okorshenko self-assigned this Oct 25, 2017
@okorshenko okorshenko added this to the October 2017 milestone Oct 25, 2017
@okorshenko okorshenko added Release Line: 2.2 2.2.x bug report Component: Catalog Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release labels Oct 25, 2017
@okorshenko okorshenko merged commit 70d7502 into magento:2.2-develop Oct 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Component: Catalog Progress: accept Release Line: 2.2 Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants