-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue #4470: allow numbers in vendor and class names #11062
Conversation
[mpi] MAGETWO-72551: Update version in composer to 2.2.1-dev for 2.2-develop branch
To be consistent with the enhanced xsd schemas the tests needed to be adapted.
The problem is, that there is a difference between what you can use as Model an what is validated by the xsd file.
Any idea why we need underscore allowed? |
0c0393d
to
e442de5
Compare
|
@nhp thank you for this contribution. Provided regex allows invalid value such as
|
Hi @nhp If you wish to proceed please create a new PR or reopen this one fixing up the history. Thank you. |
As there are many companies that use numbers in their name it would be good to allow those to use them in their classes and vendor names.
Description
To enable a widely used naming scheme, with numbers, the xsd files needed to be adapted else the names could not be validated
Fixed Issues (if relevant)
Contribution checklist