Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.2-develop] Unable to manage (install/uninstall) cron via bin/magento cron:install / cron:remove with multiple installations against same crontab #11359

Merged
merged 1 commit into from
Oct 16, 2017
Merged

[Backport 2.2-develop] Unable to manage (install/uninstall) cron via bin/magento cron:install / cron:remove with multiple installations against same crontab #11359

merged 1 commit into from
Oct 16, 2017

Conversation

adrian-martinez-interactiv4
Copy link
Contributor

@adrian-martinez-interactiv4 adrian-martinez-interactiv4 commented Oct 11, 2017 •
edited
Loading

Description

Unable to manage (install/uninstall) cron via bin/magento cron:install / cron:remove with multiple installations against same crontab. Having two (or more) installations in different folders, it's not possible to create different crontab entries for both of them, because of the same prefix and suffix used for both of them (#~ MAGENTO START and #~ MAGENTO END)

Fixed Issues (if relevant)

No related issue found

Manual testing scenarios

  1. Install Magento 2 in two different folders.
  2. Run bin/magento cron:install on both of them
  3. The second one fails because the first one already installed a cron entry

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

This was referenced Oct 11, 2017
Merged
Merged
@vkublytskyi vkublytskyi self-assigned this Oct 11, 2017
@vkublytskyi vkublytskyi added this to the October 2017 milestone Oct 11, 2017
@adrian-martinez-interactiv4 adrian-martinez-interactiv4 force-pushed the FR22#CRON-INSTALL-MULTIPLE-INSTANCES branch from c1565cf to 99cabc4 Compare October 12, 2017 17:58
@adrian-martinez-interactiv4 adrian-martinez-interactiv4 force-pushed the FR22#CRON-INSTALL-MULTIPLE-INSTANCES branch from 99cabc4 to 79e9054 Compare October 13, 2017 02:42
@adrian-martinez-interactiv4 adrian-martinez-interactiv4 changed the title Unable to manage (install/uninstall) cron via bin/magento cron:install / cron:remove with multiple installations against same crontab [Backport 2.2-develop] Unable to manage (install/uninstall) cron via bin/magento cron:install / cron:remove with multiple installations against same crontab Oct 13, 2017
@okorshenko okorshenko self-assigned this Oct 16, 2017
@okorshenko okorshenko merged commit 79e9054 into magento:2.2-develop Oct 16, 2017
okorshenko pushed a commit that referenced this pull request Oct 16, 2017
MAGETWO-81577: Unable to manage (install/uninstall) cron via bin/mage…
b7be473 
…nto cron:install / cron:remove with multiple installations against same crontab #11359
@adrian-martinez-interactiv4 adrian-martinez-interactiv4 deleted the FR22#CRON-INSTALL-MULTIPLE-INSTANCES branch October 17, 2017 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@vkublytskyi vkublytskyi

@okorshenko okorshenko

Labels
Award: complex Award: special achievement Award: test coverage Progress: accept Release Line: 2.2
Projects
None yet
Milestone
October 2017
Development

Successfully merging this pull request may close these issues.
4 participants
@adrian-martinez-interactiv4 @magento-team @vkublytskyi @okorshenko