Remove unneeded, also mistyped, saveHandler from CatalogSearch indexer declaration #11626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…earch indexer.xml file
orlangur
approved these changes
Nov 1, 2017
magento-team
pushed a commit
that referenced
this pull request
Nov 2, 2017
…ogSearch indexer declaration #11626
magento-team
pushed a commit
that referenced
this pull request
Nov 2, 2017
[EngCom] Public Pull Requests - develop - MAGETWO-83154: [2.3-develop] Order grid - Sort by Purchase Date Desc by default #11931 - MAGETWO-83101: [Backport 2.3-develop] #8236 FIX CMS blocks #11805 - MAGETWO-83092: Remove unneeded, also mistyped, saveHandler from CatalogSearch indexer declaration #11626 - MAGETWO-83091: Remove "Undefined fields" from under lib folder #11662 - MAGETWO-83083: 10195: Order relation child is not set during edit operation #11909 - MAGETWO-82998: [2.3-develop] X-Magento-Tags header containing whitespaces causes exception #11849 - MAGETWO-82633: #11409: Too many password reset requests even when disabled in settings #11434
adrian-martinez-interactiv4
deleted the
FR#CATALOGSEARCH-INDEX-REMOVE-UNNEEDED-SAVEHANDLER
branch
This was referenced Dec 27, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unneeded, also mistyped, saveHandler from CatalogSearch indexer declaration.
Description
This PR removes unneeded from Magento/CatalogSearch/etc/indexer.xml:
It's not used, and it is mistyped: no such class
Magento\CatalogSearch\Model\Indexer\IndexHandlerexists; it refers instead toMagento\CatalogSearch\Model\Indexer\IndexerHandler. Even it is mistyped, it works due toMagento\CatalogSearch\Model\Indexer\IndexerHandlerFactoryhandling the save handlers, and correct class name is injected into IndexerHandlerFactory via Magento/CatalogSearch/etc/di.xml:Fixed Issues (if relevant)
None. This is a little improvement for this file, to remove that misleading saveHandler declaration, and since it's not really a problem, it makes no sense to backport it.
Manual testing scenarios
After removing that line, everything should work as before.
Contribution checklist