Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #11729 - negative value in excel export [M2.2] #11757

Merged
merged 1 commit into from
Oct 27, 2017

Conversation

hauso
Copy link
Contributor

@hauso hauso commented Oct 26, 2017

$dataType need to be set to 'String' instead 'Number' when value contain space (eg negative number with added space)

Fixed problem with negative values in exported XML file

Description

Added correction of dataType for negative numbers

Fixed Issues (if relevant)

  1. Exported Excel with negative number can't be opened by MS Office #11729: Exported Excel with negative number can't be opened by MS Office

Manual testing scenarios

  1. Generate export with negative value
  2. Open thru Microsoft Office XML handler with Microsoft Office Professional Plus 2013

Contribution checklist

  • not automated tests was provided

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants