Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

11700: "Something Went Wrong" error for limited access admin user #11993

Merged
merged 1 commit into from
Nov 7, 2017
Merged

11700: "Something Went Wrong" error for limited access admin user #11993

merged 1 commit into from
Nov 7, 2017

Conversation

RomaKis
Copy link
Contributor

@RomaKis RomaKis commented Nov 3, 2017 •
edited by magento-engcom-team
Loading

When user has access to Dashboard and don't has access to notification, error "something went wrong" appears, because ajax request try to get notifications, but magento try to redirect to "noroute".

Description

If it is ajax request don't redirect anyway, simple return nothing.

Fixed Issues (if relevant)

  1. "Something Went Wrong" error for limited access admin user #11700: "Something Went Wrong" error for limited access admin user
  2. Error message for user with restricted user role #12149: Error message for user with restricted user role

Manual testing scenarios

  1. Login as an admin user with limited access(Without notification permission).
  2. Something went wrong error pops up after every page load.
  3. Server Logs and Magento Logs don't record any errors.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@ishakhsuvarov ishakhsuvarov self-assigned this Nov 4, 2017
@ishakhsuvarov ishakhsuvarov added this to the November 2017 milestone Nov 4, 2017
@ishakhsuvarov ishakhsuvarov added Release Line: 2.2 Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Nov 4, 2017
@magento-team magento-team merged commit c113626 into magento:2.2-develop Nov 7, 2017
magento-team pushed a commit that referenced this pull request Nov 7, 2017
@ishakhsuvarov
MAGETWO-83270: 11700: "Something Went Wrong" error for limited access…
61a9a5e 
… admin user #11993
magento-team pushed a commit that referenced this pull request Nov 7, 2017
@ishakhsuvarov
Merge pull request #1671 from magento-engcom/2.2-develop-prs
c896f2c 
[EngCom] Public Pull Requests - 2.2-develop
 - MAGETWO-83279: Magento 2.2.0 Solution for Cross-sell product placeholder image size … #12018
 - MAGETWO-83270: 11700: "Something Went Wrong" error for limited access admin user #11993
 - MAGETWO-83085: fix #8846: avoid duplicated attribute option values #11785
@magento-engcom-team magento-engcom-team added Fixed in 2.2.x The issue has been fixed in 2.2 release line Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release labels Nov 10, 2017
@divivu divivu mentioned this pull request Apr 11, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ishakhsuvarov ishakhsuvarov

Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Progress: accept Release Line: 2.2 Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Milestone
November 2017
Development

Successfully merging this pull request may close these issues.
4 participants
@RomaKis @magento-team @ishakhsuvarov @magento-engcom-team