Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve urn in xhtml #12031

Merged
merged 1 commit into from
Nov 9, 2017
Merged

Improve urn in xhtml #12031

merged 1 commit into from
Nov 9, 2017

Conversation

enriquei4
Copy link
Contributor

@enriquei4 enriquei4 commented Nov 5, 2017 •
edited
Loading

Description

Improve the urn of xhtml templates.

Fixed Issues (if relevant)

  1. XHTML templates Don't Use Schema URNs #6661: XHTML templates Don't Use Schema URNs

Manual testing scenarios

Check the noNamespaceSchemaLocation of the files:
app/code/Magento/Ui/view/base/ui_component/templates/container/default.xhtml
app/code/Magento/Ui/view/base/ui_component/templates/export/button.xhtml
app/code/Magento/Ui/view/base/ui_component/templates/form/collapsible.xhtml
app/code/Magento/Ui/view/base/ui_component/templates/form/default.xhtml
app/code/Magento/Ui/view/base/ui_component/templates/listing/default.xhtml

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@dmanners dmanners self-assigned this Nov 5, 2017
@dmanners dmanners added this to the November 2017 milestone Nov 5, 2017
@dmanners dmanners added Release Line: 2.2 2.2.x bug report Area: Frontend Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Nov 5, 2017
@okorshenko okorshenko merged commit bce7d56 into magento:2.2-develop Nov 9, 2017
okorshenko pushed a commit that referenced this pull request Nov 9, 2017
@ishakhsuvarov
MAGETWO-83281: Improve urn in xhtml #12031
77a05f9
@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Nov 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmanners dmanners dmanners approved these changes

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

Assignees

@dmanners dmanners

Labels
Area: Frontend bug report bugfix Fixed in 2.2.x The issue has been fixed in 2.2 release line Progress: accept Release Line: 2.2 Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Milestone
November 2017
Development

Successfully merging this pull request may close these issues.
6 participants
@enriquei4 @dmanners @ihor-sviziev @magento-team @okorshenko @magento-engcom-team