Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Products in cart report error when we have grouped or bundle product #12082

Merged
merged 3 commits into from
Nov 9, 2017

Conversation

mihaifaget
Copy link

Description

Changed inner join with left join for prices because bundle and grouped products don't have prices and report generates error if we have them in cart.

Fixed Issues

#12079:Products in cart report error when we have grouped or bundle product

Manual testing scenarios

  1. Add a grouped or a bundle product to cart.
  2. Go to admin->Reports->Marketing->Products in cart and loop through pages or export to csv/excel
  3. Looping through pages or exporting should no longer generate error

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Nov 7, 2017

CLA assistant check
All committers have signed the CLA.

@ishakhsuvarov ishakhsuvarov self-assigned this Nov 8, 2017
@ishakhsuvarov ishakhsuvarov added this to the November 2017 milestone Nov 8, 2017
@ishakhsuvarov ishakhsuvarov added Release Line: 2.2 2.2.x Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Nov 8, 2017
@ishakhsuvarov
Copy link
Contributor

Hi @mihaifaget
Could you please take a look at the failed tests on Travis CI?
Thanks

@mihaifaget
Copy link
Author

Hi @ishakhsuvarov
Saw the failed test, but doesn't make sense to me, the only thing I changed was joinInner with joinLeft and I already have it functional on a project.

@ishakhsuvarov
Copy link
Contributor

@mihaifaget We can not accept Pull Requests with failed builds, please fix the error or let us know if you need help with this.

@mihaifaget mihaifaget closed this Nov 9, 2017
@mihaifaget
Copy link
Author

ok, I closed it

@ishakhsuvarov ishakhsuvarov reopened this Nov 9, 2017
@ishakhsuvarov
Copy link
Contributor

ishakhsuvarov commented Nov 9, 2017

@mihaifaget I updated the failing test and will proceed with the merge.
Thanks.

@okorshenko okorshenko merged commit d9485cc into magento:2.2-develop Nov 9, 2017
okorshenko pushed a commit that referenced this pull request Nov 9, 2017
@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Nov 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Progress: needs update Release Line: 2.2 Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants