Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed each function usage #13450

Merged
merged 1 commit into from
Feb 2, 2018
Merged

Removed each function usage #13450

merged 1 commit into from
Feb 2, 2018

Conversation

ihor-sviziev
Copy link
Contributor

Description

Backport of PR magento-engcom/php-7.2-support#31 to 2.2-develop

Fixed Issues (if relevant)

  1. Usage of deprecated each() function magento-engcom/php-7.2-support#20: Usage of deprecated each() function

Manual testing scenarios

N/A

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@dmanners dmanners self-assigned this Feb 1, 2018
@dmanners dmanners added this to the February 2018 milestone Feb 1, 2018
@magento-engcom-team magento-engcom-team merged commit 264d502 into magento:2.2-develop Feb 2, 2018
magento-engcom-team pushed a commit that referenced this pull request Feb 2, 2018
MAGETWO-87354: Removed each function usage #13450
84a4b31
@ihor-sviziev ihor-sviziev deleted the 2.2-remove-each-function-usage branch February 13, 2018 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmanners dmanners dmanners approved these changes

Assignees

@dmanners dmanners

Labels
Progress: accept Release Line: 2.2
Projects
None yet
Milestone
February 2018
Development

Successfully merging this pull request may close these issues.
4 participants
@ihor-sviziev @dmanners @magento-engcom-team @YevSent