Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed breadcrumb quote issue in product page #16148

Merged
merged 2 commits into from
Jun 26, 2018
Merged

Fixed breadcrumb quote issue in product page #16148

merged 2 commits into from
Jun 26, 2018

Conversation

jignesh-baldha
Copy link
Member

@jignesh-baldha jignesh-baldha commented Jun 15, 2018

Original pull request

#15347

Fixed breadcrumb quote issue in product page #15037

Description

I've fixed quote issue in breadcrumb in product view page.

Fixed Issues (if relevant)

  1. Product Details Page breadcrumbs cause syntax error on products containing quotes #15037: Product Details Page breadcrumbs cause syntax error on products containing quotes

Manual testing scenarios

  1. Add double quote in product name and check breadcrumb in product view page.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Jun 15, 2018

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @jignesh-baldha. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on Pull Request changes
  • @magento-engcom-team give me new test instance - deploy NEW test instance based on Pull Request changes
  • @magento-engcom-team give me {$VERSION} instance - deploy Vanilla Magento instance for Issue or Pull Request

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @jignesh-baldha. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.3.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants