Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Remove double semicolon from the style sheets. #16809

Merged

Conversation

gelanivishal
Copy link
Contributor

Original Pull Request

#15795

Description

Remove double semicolon from the style sheets.

Fixed Issues (if relevant)

N/A

Manual testing scenarios

N/A

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@sidolov
Copy link
Contributor

sidolov commented Jul 15, 2018

@gelanivishal , please, make the same changes as an original PR, currently, your PR contains extra changes.

@gelanivishal
Copy link
Contributor Author

@sidolov There is coding standard changes. I have just removed extra space and tab issue. Please check it.

Thank you.

@gelanivishal
Copy link
Contributor Author

@sidolov Have you checked my message?

Thank you.

@sidolov
Copy link
Contributor

sidolov commented Jul 23, 2018

Hi @gelanivishal , please, sort all CSS properties alphabetically according to our LESS coding standards

@gelanivishal
Copy link
Contributor Author

@sidolov Is there any online tool?

@sidolov
Copy link
Contributor

sidolov commented Jul 23, 2018

@gelanivishal , unfortunately, our team doesn't provide any tools for that case. You may find the tool by yourself or fix issues manually.

@gelanivishal
Copy link
Contributor Author

@sidolov Please review the latest commit.

@magento-engcom-team
Copy link
Contributor

Hi @gelanivishal. Thank you for your contribution.
We will aim to release these changes as part of 2.1.15.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants