-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding property mapper for product eav attribute -> search weight. #17668
Adding property mapper for product eav attribute -> search weight. #17668
Conversation
Hi @bartek9007. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
@magento-engcom-team Code quality check showed that I have unused param, but it is required by interface implemented by parent class. Other implementations also not necessarily uses this param. |
a58ea9a
to
b7da4be
Compare
@bartoszkubicki Thank you for your contribution. Can you please fix the failing tests? The unused parameter can probably be ignored. |
@josefbehr How it can be ommited if property mappers should implement |
@bartoszkubicki I meant you can ignore the warning about the unused parameter, not remove it :) What about my other questions? |
d25ed36
to
40363f0
Compare
@josefbehr I have added some changes, I hope that test failures will be gone. |
c924ca6
to
34652e4
Compare
@bartoszkubicki Looking good, thanks. Can you please answer my other questions, and suppress the warning about the unused variable? |
@josefbehr Didn't notice your edit. I have faced this problem by myself. When adding product attribute programatically, search weight of attributes wasn't persisted to db (table |
Adding property mapper for product eav attribute -> search weight - cs fixes. Adding return types. Adding return types. Adding return types.
9de0248
to
83fa42d
Compare
Hi @josefbehr, thank you for the review. |
✔️ QA Passed |
Hi @bartoszkubicki, thank you for your contribution! |
Description
This PR creates property mapper of type
Magento\Eav\Model\Entity\Setup\PropertyMapperAbstract
to make sure, while adding new product attribute programatically its search weight is persisted into db. Apart of it, unit test for property mapper provided.Fixed Issues (if relevant)
Manual testing scenarios
magento/module-eav/Setup/EavSetup.php:addAttribute()
Contribution checklist