Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Forwardport] [FEATURE] [issue-3283] Added Filter Support for Yes/No (boolean) #18501

Closed

Conversation

gelanivishal
Copy link
Contributor

Original Pull Request

#17823

…ibutes

Description

Currently it is only possible to set an attribute to is_filterable to attributes with catalog input type Dropdown, Multiple Select and Price. But in some cases you want a Yes/No (boolean) attribute to be filterable.

Fixed Issues (if relevant)

  1. «Yes/No» attributes should be allowed in the Layered Navigation #3283: «Yes/No» attributes should be allowed in the Layered Navigation

Manual testing scenarios

Before:
1.
image

image

After:
1.
image
2.
image
3. After a reindex the attribute will be displayed as a filter!

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@sidolov
Copy link
Contributor

sidolov commented Oct 10, 2018

Hi @gelanivishal , I'm closing this PR as duplicate for #18434

@sidolov sidolov closed this Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants