Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magento 2.2.6 Terms and Conditions are Not visible in Admin #18963

Closed
wants to merge 1 commit into from
Closed

Magento 2.2.6 Terms and Conditions are Not visible in Admin #18963

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Oct 31, 2018

Description (*)

Install Magento v2.2.6 with table prefix, then the Terms and Conditions Grid was not working.

Fixed Issues (if relevant)

  1. Magento 2.2.6 Terms and Conditions are Not visible in Admin #18954: Magento 2.2.6 Terms and Conditions are Not visible in Admin

Manual testing scenarios (*)

  1. Install Magento with table prefix.
  2. Go to admin
  3. Go to Store -> Terms and Conditions.
  4. Add a New Condition
  5. Save Condition

Error Message in system.log file:
main.CRITICAL: SQLSTATE[42S02]: Base table or view not found: 1146 Table 'praveensagar_magento226.checkout_agreement_store' doesn't exist, query was: SELECT agreement_store.* FROM checkout_agreement_store AS agreement_store WHERE (agreement_store.agreement_id IN ('1')) [] []

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @ayazwebkul. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@sidolov
Copy link
Contributor

sidolov commented Oct 31, 2018

Hi @ayazwebkul , looks like we already have PR with the same changes: #18866
I'm closing this PR as duplicate.
Thank you for the contribution!

@sidolov sidolov closed this Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants