Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for currency update in crontab area #18981

Merged
merged 1 commit into from
Feb 12, 2019
Merged

Fix for currency update in crontab area #18981

merged 1 commit into from
Feb 12, 2019

Conversation

denispapec
Copy link
Member

Description (*)

This PR fixes issue where cron doesn't updates currency rates if they aren't enabled in default store.
This PR is for 2.3 Release line.

Fixed Issues (if relevant)

  1. Currency rates not updated by crontab #18580: Currency rates not updated by crontab

Manual testing scenarios (*)

  1. Base store has only one allowed currency (EUR). So EUR is the base currency.
  2. English store has 4 allowed currencies (EUR, CAD, USD, GBP).
  3. Enable Fixer.io conversion service and enable it.
  4. Save manually incorrect rates for CAD, USD and GBP.
  5. Run cron currency_rates_update
  6. Confirm that all rates are updated to real values.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @denispapec. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

Copy link

@jcourtei jcourtei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@denispapec Thanks!

@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-4165 has been created to process this Pull Request

@ghost
Copy link

ghost commented Feb 12, 2019

Hi @denispapec, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants