Curl - allow setting HTTP version

[ghost]

Description

Added allow for setting curl http version

Fixed Issues (if relevant)

1. Magento/Framework/HTTP/Adapter/Curl.php doesn't allow setting HTTP version #19442: Magento/Framework/HTTP/Adapter/Curl.php doesn't allow setting HTTP version

Manual testing scenarios (*)

1. Create new ZendClient $client
2. Set HTTP version $client->setConfig(['httpversion' => CURL_HTTP_VERSION_1_1])
3. Make a request $client->request()

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

Additional information

1. Curl - allow setting HTTP version #19445: Recovered Pull Request

[magento-engcom-team]

Hi @SikailoISM. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[magento-engcom-team]

Hi @sivaschenko, thank you for the review.
ENGCOM-3710 has been created to process this Pull Request

[ryanreeves-taxjar]

Is it possible to bypass the Codacy/PR Quality Review? It fails on the use of curl_setopt, but I don't think that guideline should apply since the write method already calls that function several times.

[sivaschenko]

Hi @ryanreeves-taxjar , yes, I think that codacy can be ignored in this particular case.

[perfpcs]

Can I get an update when this issue will be resolved? It seems like this will happen in 2,3.1, correct? What is the estimate time release for 2.3.1?

[sivaschenko]

Hi @SikailoISM , sorry for delays in processing and response, it will be soon merged to mainline

[ghost]

Hi @SikailoISM, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[YevSent]

This fix breaks existing functionality, curl_setopt with CURLOPT_HTTP_VERSION requires a digit 0-3 but not a string. See http://php.net/manual/en/function.curl-setopt.php