-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed checkout page product options alignment in order summary #20138
Conversation
Hi @mage2pratik. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
Hi @miguelbalparda, thank you for the review. |
Hello @mage2pratik Our QA engineer tested your fix and everything is OK. But he found small inconsistency now between "Checkout Summary Block" and "Mini-Cart" after the fix. Could you please apply the same fix to mini-cart as well? Anyway, thank you for contribution and collaboration! |
Hi @sdzhepa : I've updated code related for Mini-Cart design. |
@magento-engcom-team give me test instance |
Hi @sdzhepa. Thank you for your request. I'm working on Magento instance for you |
Hi @sdzhepa, here is your new Magento instance. |
@magento-engcom-team give me 2.3-develop instance |
Hi @sdzhepa. Thank you for your request. I'm working on Magento 2.3-develop instance for you |
Hi @sdzhepa, here is your Magento instance. |
Hi @mage2pratik While working on this PR I faced small new style issue in mini-cart. Thank you for contribution and collaboration! |
@magento-engcom-team give me test instance |
Hi @sdzhepa. Thank you for your request. I'm working on Magento instance for you |
Hi @sdzhepa, here is your new Magento instance. |
Hi @mage2pratik I have verified PR after last fix and can confirm issue is fixed. Thank you for contribution and collaboration! |
Hi @sdzhepa, thank you for the review. |
Hi @mage2pratik, thank you for your contribution! |
Description (*)
Fixed checkout page product options alignment in order summary.
Fixed Issues (if relevant)
Manual testing scenarios (*)
Contribution checklist (*)