Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed checkout page product options alignment in order summary #20138

Merged
merged 3 commits into from
Feb 10, 2019

Conversation

mage2pratik
Copy link
Contributor

@mage2pratik mage2pratik commented Jan 9, 2019

Description (*)

Fixed checkout page product options alignment in order summary.

Fixed Issues (if relevant)

  1. On checkout page product options is not align in order summary #20134: On checkout page product options is not align in order summary

Manual testing scenarios (*)

  1. add product to cart
  2. and go to checkout page in order summary

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @mage2pratik. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Jan 14, 2019
@magento-engcom-team
Copy link
Contributor

Hi @miguelbalparda, thank you for the review.
ENGCOM-3854 has been created to process this Pull Request

@sdzhepa
Copy link
Contributor

sdzhepa commented Jan 18, 2019

Hello @mage2pratik

Our QA engineer tested your fix and everything is OK.

But he found small inconsistency now between "Checkout Summary Block" and "Mini-Cart" after the fix.
example

Could you please apply the same fix to mini-cart as well?

Anyway, thank you for contribution and collaboration!

@mage2pratik
Copy link
Contributor Author

Hi @sdzhepa : I've updated code related for Mini-Cart design.

@sdzhepa
Copy link
Contributor

sdzhepa commented Jan 29, 2019

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @sdzhepa. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @sdzhepa, here is your new Magento instance.
Admin access: https://pr-20138.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@sdzhepa sdzhepa self-assigned this Jan 29, 2019
@sdzhepa sdzhepa self-requested a review January 29, 2019 10:16
@sdzhepa
Copy link
Contributor

sdzhepa commented Jan 29, 2019

@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @sdzhepa. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @sdzhepa, here is your Magento instance.
Admin access: https://i-20138-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@sdzhepa
Copy link
Contributor

sdzhepa commented Jan 29, 2019

Hi @mage2pratik

While working on this PR I faced small new style issue in mini-cart.
Could you please have a look and fix it?

pr20138

Thank you for contribution and collaboration!

@sdzhepa
Copy link
Contributor

sdzhepa commented Jan 30, 2019

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @sdzhepa. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @sdzhepa, here is your new Magento instance.
Admin access: https://pr-20138.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@sdzhepa
Copy link
Contributor

sdzhepa commented Jan 30, 2019

Hi @mage2pratik

I have verified PR after last fix and can confirm issue is fixed.
I put PR into delivery queue.

Thank you for contribution and collaboration!

@magento-engcom-team
Copy link
Contributor

Hi @sdzhepa, thank you for the review.
ENGCOM-3854 has been created to process this Pull Request

@ghost
Copy link

ghost commented Feb 10, 2019

Hi @mage2pratik, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants