Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

magento/magento2#16198: Category image remain after deleted. #20178

Merged
merged 2 commits into from
Jan 18, 2019

Conversation

p-bystritsky
Copy link
Contributor

Description

Fixed Issues (if relevant)

  1. Category image remain after deleted #16198: Category image remain after deleted.

Manual testing scenarios

  1. Go to Admin > Catalog > Categories
  2. Upload image via field Category Image under Content section > Save
  3. Click on trash icon to remove image > Save
  4. Image under pub\media\catalog\category should be removed

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @p-bystritsky. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added this to the Release: 2.2.8 milestone Jan 10, 2019
@sivaschenko
Copy link
Member

Hi @p-bystritsky thanks for the contribution, can you please also port this PR to 2.3-develop branch to ensure it will be merged there as well.

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-3826 has been created to process this Pull Request

@ghost
Copy link

ghost commented Jan 18, 2019

Hi @p-bystritsky, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team
Copy link
Contributor

Hi @p-bystritsky. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

@p-bystritsky
Copy link
Contributor Author

Port to 2.3 is not needed as issue is not reproducible on 2.3-develop branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants