Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added original exception as the cause to the new exception on product delete error #20578

Conversation

woutersamaey
Copy link
Contributor

Description (*)

When Magento can't delete a product a new exception is thrown, but the original exception is not passed to the new exception as the original "cause"

Fixed Issues (if relevant)

Just better error handling

Manual testing scenarios (*)

Just better error handling

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @woutersamaey. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@federivo federivo self-assigned this Jan 29, 2019
Copy link
Member

@federivo federivo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes approved.

@magento-engcom-team
Copy link
Contributor

Hi @federivo, thank you for the review.
ENGCOM-4021 has been created to process this Pull Request

@federivo
Copy link
Member

Hi @woutersamaey! Thanks for your contribution.

When merged, consider back-porting this to 2.2. You can easily achieve it using the Porting Tool, check here.

@magento-engcom-team magento-engcom-team merged commit 02d7b93 into magento:2.3-develop Mar 1, 2019
@ghost
Copy link

ghost commented Mar 1, 2019

Hi @woutersamaey, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Mar 1, 2019
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.2 milestone Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants