Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full Tax Summary display wrong numbers #20682

Merged
merged 8 commits into from
Feb 14, 2019

Conversation

niravkrish
Copy link
Contributor

Description (*)

The full tax summary is displaying total tax, instead of showing individual tax value.

Fixed Issues (if relevant)

  1. Magento 2.3 Shopping Cart Taxes Missing Calc Line #19701: Magento 2.3 Shopping Cart Taxes Missing Calc Line
  2. Full Tax Summary display wrong numbers. #11358: Full Tax Summary display wrong numbers.

Manual testing scenarios (*)

  1. Manual Testing

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @niravkrish. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@davidverholen
Copy link
Member

@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @davidverholen. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @davidverholen, here is your Magento instance.
Admin access: https://i-20682-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@davidverholen
Copy link
Member

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @davidverholen. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @davidverholen, here is your new Magento instance.
Admin access: https://pr-20682.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@magento-engcom-team
Copy link
Contributor

Hi @davidverholen, thank you for the review.
ENGCOM-4022 has been created to process this Pull Request

@niravkrish niravkrish added Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release and removed Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release labels Feb 6, 2019
@niravkrish
Copy link
Contributor Author

Hello @magento-engcom-team,

I have a doubt here regarding release line.
you have mentioned release line 2.3 but it should be like 2.3.X because 2.3 is already released.
Please clear me in that.
Thanks in advanced

@ghost
Copy link

ghost commented Feb 14, 2019

Hi @niravkrish, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants