Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

14857: prevent cache drop for frontend caches on sitemap generation #20818

Merged
merged 3 commits into from
Mar 5, 2019
Merged

14857: prevent cache drop for frontend caches on sitemap generation #20818

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b9190b3
14857: prevent cache drop for frontend caches on sitemap generation
david-fuehr Jan 30, 2019
ebc266b
amend touched DocBlocks
david-fuehr Jan 31, 2019
28a9720
Fix static tests.
nmalevanec Mar 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions app/code/Magento/Robots/Model/Config/Value.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
*/

namespace Magento\Robots\Model\Config;

use Magento\Framework\App\Cache\TypeListInterface;
Expand Down Expand Up @@ -32,12 +33,11 @@ class Value extends ConfigValue implements IdentityInterface
const CACHE_TAG = 'robots';

/**
* Model cache tag for clear cache in after save and after delete
* @inheritdoc
*
* @var string
* @since 100.2.0
*/
protected $_cacheTag = true;
protected $_cacheTag = [self::CACHE_TAG];

/**
* @var StoreManagerInterface
Expand Down
8 changes: 5 additions & 3 deletions app/code/Magento/Sitemap/Model/Sitemap.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
*/

namespace Magento\Sitemap\Model;

use Magento\Config\Model\Config\Reader\Source\Deployed\DocumentRoot;
Expand All @@ -15,6 +16,8 @@
use Magento\Sitemap\Model\ResourceModel\Sitemap as SitemapResource;

/**
* Sitemap model.
*
* @method string getSitemapType()
* @method \Magento\Sitemap\Model\Sitemap setSitemapType(string $value)
* @method string getSitemapFilename()
Expand Down Expand Up @@ -154,12 +157,11 @@ class Sitemap extends \Magento\Framework\Model\AbstractModel implements \Magento
protected $dateTime;

/**
* Model cache tag for clear cache in after save and after delete
* @inheritdoc
*
* @var string
* @since 100.2.0
*/
protected $_cacheTag = true;
protected $_cacheTag = [Value::CACHE_TAG];
david-fuehr marked this conversation as resolved.
Show resolved Hide resolved

/**
* Item resolver
Expand Down