Fixed issue if there are multiple skus in catalog rule condition combination

[suneet64]

Fixed issue if there are multiple skus in catalog rule condition combination

Description (*)

In catalog rule, if there are multiple skus and the condition is 'in one of' then the discount applies only on the first sku.

Fixed Issues (if relevant)

Manual testing scenarios (*)

1. Have a Magento v2.3 clean installation.
2. Go to Stores > Attributes > Product and edit sku attribute.
3. Go to Storefront Properties tab and set YES for Use for Promo Rule Conditions.
4. Go to Marketing > Promotions > Catalog Price Rule and Add New Rule.
5. Create a new rule, select SKU as the product attribute from the condition dropdown, select is one of as a condition and select more than one SKU in the value.
6. Click on Save and Apply.
7. Refresh Magento cache by navigating System > Tools > Cache Management.
8. Before: On the frontend, the discount applies only on the first SKU from the condition.
   After: The discount applies on all the products from the condition.

Following are the before after videos of the issue:

Before Video

After Video

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-engcom-team]

Hi @suneet64. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[aleron75]

Tested locally, works for me

[aleron75]

Hello @suneet64, thanks for your contribution!

Once merged, don't forget you can easily port this PR (if needed) to other branches with the Porting Tool, read more here.

[magento-engcom-team]

Hi @aleron75, thank you for the review.
ENGCOM-4149 has been created to process this Pull Request

[ghost]

Hi @suneet64, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.