Fix empty cart validation

[wojtekn]

Description

This PR prevents from running UpdateItemQty validation before Clear Shopping Cart action is triggered. In the other case validation breaks for use case in which product existing in cart went out of stock in the meantime.

Fixed Issues

1. Cart can't be emptied if any product is out of stock #21294

Manual testing scenarios

1. Add simple product in backend, set positive quantity and Stock Status = In Stock
2. Open another browser tab and access product in frontend
3. Add product to cart
4. Navigate to cart
5. Enable "Clear Shopping Cart" button by running this code in console:
   jQuery('.action.clear').show()
   It's hidden in CSS for some reason.
6. Back to product form in the backend
7. Set Stock Status for product to Out of Stock, save
8. Click "Clear Shopping Cart" button in the cart in frontend

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-cicd2]

All committers have signed the CLA.

[magento-engcom-team]

Hi @wojtekn. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[wojtekn]

@magento-engcom-team give me test instance

[magento-engcom-team]

Hi @wojtekn. Thank you for your request. I'm working on Magento instance for you

[magento-engcom-team]

Hi @wojtekn, here is your new Magento instance.
Admin access: https://pr-21295.instances.magento-community.engineering/admin
Login: admin Password: 123123q

[wojtekn]

Issue doesn't reproduce on test instance based on PR changes.

[swnsma]

@magento-engcom-team give me 2.3-develop instance

[magento-engcom-team]

Hi @swnsma. Thank you for your request. I'm working on Magento 2.3-develop instance for you

[magento-engcom-team]

Hi @swnsma, here is your Magento instance.
Admin access: https://i-21295-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

[swnsma]

Hi @wojtekn,

Thank you for you contribution!

1. Please check failed JS static tests.
2. Could you remove hard-coded jQuery selected from the component and pass it like variable:
   

   magento2/app/code/Magento/Checkout/view/frontend/templates/cart/form.phtml

   Line 28 in 94383aa

   "updateCartActionContainer": "#update_cart_action_container"}}'>

[swnsma]

@wojtekn, thanks!

I will check after Travis report will be ready.

[magento-engcom-team]

Hi @swnsma, thank you for the review.
ENGCOM-4362 has been created to process this Pull Request

[ghost]

Hi @wojtekn, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.