Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed : Additional addresses DataTable Pagination count displaying wrong #21399

Merged
merged 17 commits into from
Mar 25, 2019
Merged

Fixed : Additional addresses DataTable Pagination count displaying wrong #21399

merged 17 commits into from
Mar 25, 2019

Conversation

Dharmeshvaja91
Copy link
Contributor

Description (*)

My Account > My addresses > additional address DataTable Pagination count displaying wrong.

Fixed Issues (if relevant)

  1. [Frontend] Additional addresses DataTable Pagination count displaying wrong. #21396: Additional addresses DataTable Pagination count displaying wrong

Manual testing scenarios (*)

  1. Go to My account >> Address book
  2. Add more than 2 additional address.
  3. Select different Shipping and Billing Address.
  4. Review Additional Address Data Table pagination count.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Dharmeshvaja91 and others added 10 commits January 28, 2019 18:06
@magento-engcom-team
Copy link
Contributor

Hi @Dharmeshvaja91. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@rogyar
Copy link
Contributor

rogyar commented Feb 23, 2019

Hi @Dharmeshvaja91. Please, consider fixing failing unit tests

@rogyar rogyar self-assigned this Feb 23, 2019
@rogyar
Copy link
Contributor

rogyar commented Mar 18, 2019

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @rogyar. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, here is your new Magento instance.
Admin access: https://pr-21399.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-4523 has been created to process this Pull Request

@VasylShvorak VasylShvorak self-assigned this Mar 20, 2019
@VasylShvorak
Copy link
Contributor

✔️ QA passed

@nmalevanec nmalevanec self-assigned this Mar 20, 2019
@magento-engcom-team magento-engcom-team mentioned this pull request Mar 25, 2019
Closed
@magento-engcom-team magento-engcom-team merged commit 50ce1f5 into magento:2.3-develop Mar 25, 2019
@ghost
Copy link

ghost commented Mar 25, 2019

Hi @Dharmeshvaja91, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Mar 25, 2019
@sidolov
ENGCOM-4523: Fixed : Additional addresses DataTable Pagination count …
b451abc 
…displaying wrong #21399
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.2 milestone Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogyar rogyar rogyar approved these changes

@le0n4eg le0n4eg Awaiting requested review from le0n4eg

Assignees

@rogyar rogyar

@nmalevanec nmalevanec

@VasylShvorak VasylShvorak

Labels
Award: bug fix Component: Customer Partner: Krish TechnoLabs partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.2
Development

Successfully merging this pull request may close these issues.
5 participants
@Dharmeshvaja91 @magento-engcom-team @rogyar @VasylShvorak @nmalevanec