-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport] Fix Broken Tax Rate Search Filter Admin grid #21521 #21535
Conversation
Hi @tuyennn. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
@magento-engcom-team give me test instance |
Hi @tuyennn. Thank you for your request. I'm working on Magento instance for you |
Hi @tuyennn, here is your new Magento instance. |
@magento-engcom-team give me 2.2-develop instance |
Hi @tuyennn. Thank you for your request. I'm working on Magento 2.2-develop instance for you |
Hi @tuyennn, here is your Magento instance. |
Hi @aleron75, thank you for the review. |
✔️ QA passed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @tuyennn , in order to keep consistency between versions we accepting pull requests to 2.3-develop first. Please, create pull request with the same changes to 2.3-develop
Duplicate #21758 |
Hi @sivaschenko, thank you for the review. |
Hi @tuyennn, thank you for your contribution! |
Description (*)
Inside Tax Rate admin, while search criteria with main table
tax_calculation_rule
code andtax_calculation_rate
code will caused where clause is ambiguousFixed Issues (if relevant)
Manual testing scenarios (*)
Go to Admin -> Stores -> Taxes -> Tax Rules
Add a tax rule
Search tax rule using both Name and Tax Rate fields
eg. Name = Alabama & Tax Rate = US-AL
Contribution checklist (*)
Backport for: #21701