-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Forwardport] Resolve incorrect scope code selection when the requested scopeCode is null #21633
[Forwardport] Resolve incorrect scope code selection when the requested scopeCode is null #21633
Conversation
…s null - resolves an issue whereby the incorrect scope could be returned when attempting to resolve a scope with a requested scopeCode of null - simplify the scope resolver logic to a avoid multiple if conditional checks - move scope interface class to an alias of the class - update docblock on the expected values available for scopeCode Signed-off-by: Matthew Muscat <[email protected]>
Hi @mage2pratik. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
Hi @rogyar, thank you for the review. |
Hi @mage2pratik, thank you for your contribution! |
…n the requested scopeCode is null #21633
Original Pull Request
#16940
Description
Resolves #16939
Fixed Issues (if relevant)
Manual testing scenarios
Contribution checklist