-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When setting background
for labels explicitly the labels in admin will
#21825
When setting background
for labels explicitly the labels in admin will
#21825
Conversation
overlap the `::before` pseudo-element. I suggest to remove explicit setting for `label` element or replace `@color-white` to `transparent`. In some cases developers try to hide elements by setting white background and higher z-index for the element with white background. But the proper way of hiding elements is to override templates config or remove elements by JavaScript.
Hi @TomashKhamlai. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
Hi @dmytro-ch, thank you for the review. |
Updated testing scenario |
✔️ QA passed |
Hi @TomashKhamlai, thank you for your contribution! |
When setting
background
for labels explicitly the labels in admin willoverlap the
::before
pseudo-element.I suggest to remove explicit setting for
label
element or replace@color-white
totransparent
.In some cases developers try to hide elements by setting white
background and higher z-index for the element with white background.
But the proper way of hiding elements is to override templates config or
remove elements by JavaScript.
Description (*)
Fix for the minor UI regression bug introduced in 5d3870a.
Fixed Issues (if relevant)
Before:
After:
Manual testing scenarios (*)
app/code/Magento/ConfigurableProduct/Test/Mftf/Test/AdminConfigurableProductCreateTest.xml
is passing.Additional Scenario
Expected result: Attribute Weight is visible
Contribution checklist (*)