Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#21244 Fixed WhiteSpace issue in product grid #21929

Closed
wants to merge 1 commit into from
Closed

#21244 Fixed WhiteSpace issue in product grid #21929

wants to merge 1 commit into from

Conversation

shrinet
Copy link
Contributor

@shrinet shrinet commented Mar 25, 2019

Description (*)

Fixed Issues (if relevant)

  1. Luma theme huge whitespace on category grid #21244: Luma theme huge whitespace on category grid
  2. Product per row not proper on listing page  #20140: Product per row not proper on listing page

Manual testing scenarios (*)

  1. ...
  2. ...

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

There are some whitespaces in between li tags, that's why product grid showing 3 products instead of 4 also mention in #20140
@magento-engcom-team
Copy link
Contributor

Hi @shrinet. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Mar 25, 2019

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@dmytro-ch dmytro-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @shrinet,
thank you for your contribution!

Could you please check the code review recommendations?

I guess we may also revert the fixes provided by PR #20168, don't we?

Thank you!

@@ -480,6 +480,7 @@
.products-grid {
.product-items {
margin: 0;
font-size: 0;
Copy link
Contributor

@dmytro-ch dmytro-ch Mar 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to use .lib-inline-block-space-container() and .lib-inline-block-space-item() mixins for this purpose.
Please check lib/web/css/source/lib/_utilities.less:252 for more details.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @dmytro-ch for valuable suggestion, I am making changes.

@shrinet shrinet closed this Mar 25, 2019
@ghost
Copy link

ghost commented Mar 25, 2019

Hi @shrinet, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants