Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unwanted interface implementation #22002

Merged
merged 2 commits into from
Apr 11, 2019
Merged

Removed unwanted interface implementation #22002

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e6f56b
Removed unwanted interface implementation
vishal-7037 Mar 28, 2019
8a98f20
Fix wrong interface implementation.
nmalevanec Mar 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/code/Magento/Backend/Controller/Adminhtml/Dashboard/ProductsViewed.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,12 @@
*/
namespace Magento\Backend\Controller\Adminhtml\Dashboard;

use Magento\Framework\App\Action\HttpGetActionInterface;
use Magento\Framework\App\Action\HttpPostActionInterface;

/**
* Get most viewed products controller.
*/
class ProductsViewed extends AjaxBlock implements HttpGetActionInterface
class ProductsViewed extends AjaxBlock implements HttpPostActionInterface
{
/**
* Gets most viewed products list
Expand Down
5 changes: 5 additions & 0 deletions ...tegration/testsuite/Magento/Backend/Controller/Adminhtml/Dashboard/ProductsViewedTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,12 @@
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
*/

namespace Magento\Backend\Controller\Adminhtml\Dashboard;

/**
* Test product viewed backend controller.
*/
class ProductsViewedTest extends \Magento\TestFramework\TestCase\AbstractBackendController
{
/**
Expand All @@ -14,6 +18,7 @@ class ProductsViewedTest extends \Magento\TestFramework\TestCase\AbstractBackend
*/
public function testExecute()
{
$this->getRequest()->setMethod("POST");
$this->dispatch('backend/admin/dashboard/productsViewed/');

$this->assertEquals(200, $this->getResponse()->getHttpResponseCode());
Expand Down