fix saving inactive admin user, when record doesn't exist in oauth_token table #22118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @dxx004. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
magento-engcom-team
added
Component: Integration
Release Line: 2.3
Partner: Mediotype
partners-contribution
|
|
orlangur
requested changes
Apr 2, 2019
| try { | ||
| $this->adminTokenService->revokeAdminAccessToken($object->getId()); | ||
| } catch (LocalizedException $e) { | ||
| //token for admin use doesn't exist in oauth_token table, no action |
There was a problem hiding this comment.
This exception looks like intentionally not caught before. What are other possibilities of fix?
ghost
added
the
|
Hi @dxx004, thank you for your contribution! |
|
@dxx004 oh, thanks, that's why it is a good idea to search for existing bug report :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
PR handles thrown exception during saving inactive admin user or saving admin rule with inactive admin user assigned, when record (for the admin user) doesn't exist in
oauth_tokentable.Fixed Issues (if relevant)
Manual testing scenarios (*)
the same error is shown, when trying to assign inactive admin user to admin role and save.
Contribution checklist (*)