Removed client preference from Magento\ReleaseNotification module

[tephereth]

Description (*)

A preference for ClientInterface was wrongly present in Magento\ReleaseNotification module. This fix is related to the MSI issue: magento/inventory#2128 and to the MSI pull request: magento/inventory#2144

Fixed Issues (if relevant)

Related to MSI issue: magento/inventory#2128

Manual testing scenarios (*)

Testable on MSI, see magento/inventory#2144

Contribution checklist (*)

• [x ] Pull request has a meaningful description of its purpose
• [ x] All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[m2-assistant]

Hi @tephereth. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[orlangur]

Why it is removed and not moved to https://github.com/magento/magento2/blob/2.3-develop/app/etc/di.xml?

How da443ff#diff-3c49a41920d4a1473c3cb45ad0cab3ec will work after this change?

[tephereth]

Working on this fix for MSI I've noticed that the ClientInterface preference involves many classes of InventoryDistanceBasedSourceSelection; first thought was to add type direct in the di.xml of the MSI module and ReleaseNotification module. But since most of Magento\Framework preferences are anyway stored in the general etc/di.xml, I guess the solution that @orlangur suggested is cleaner.

[orlangur]

Please squash changes into a single commit so that we have perfectly clean history 😉

[tephereth]

@orlangur, commits squashed

[orlangur]

Thanks @tephereth! Would be nice to grep for preference.*framework in app/code to catch all such also.

[magento-engcom-team]

Hi @orlangur, thank you for the review.
ENGCOM-4693 has been created to process this Pull Request

[orlangur]

This actually duplicates #21540

[m2-assistant]

Hi @tephereth, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.