-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove an unused variable from order_list fixture in the integration test suite. #22220
Remove an unused variable from order_list fixture in the integration test suite. #22220
Conversation
The $payment variable is overwritten in the foreach loop.
Hi @evktalo. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
@@ -9,6 +9,7 @@ | |||
use Magento\Sales\Model\Order\Address as OrderAddress; | |||
use Magento\Sales\Model\Order\Payment; | |||
|
|||
// phpcs:ignore Magento2.Security.IncludeFile | |||
require 'order.php'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seriously? :D We now have such rule? Lol.
Hi @evktalo, thank you for your contribution! |
… integration test suite. #22220
Description (*)
Small code clean-up for integration tests. Remove an unused variable.
Remove unused payment variable from order data. The $payment variable is overwritten in the foreach loop.
Manual testing scenarios (*)
Contribution checklist (*)