Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataExtractor unit tests coverage #25809

Merged
merged 3 commits into from
Dec 3, 2019

Conversation

kmlfadeless
Copy link
Contributor

@kmlfadeless kmlfadeless commented Nov 28, 2019

Unit tests for DataExtractor model in MediaGallery module

Description (*)

Issue 584: added unit tests for DataExtractor model

Fixed Issues

  1. Cover DataExtractor with a unit test adobe-stock-integration#584: Cover DataExtractor with a unit test

Manual testing scenarios (*)

/vendor/bin/phpunit -c dev/tests/unit/phpunit.xml.dist app/code/Magento/MediaGallery/Test/Unit/Model/DataExtractorTest.php

Contribution checklist (*)

  • [v] Pull request has a meaningful description of its purpose
  • [v] All commits are accompanied by meaningful commit messages
  • [v] All new or changed code is covered with unit/integration tests (if applicable)
  • [v] All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Nov 28, 2019

Hi @kmlfadeless. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@ghost ghost assigned sivaschenko Nov 30, 2019
@sivaschenko sivaschenko changed the title magento/adobe-stock-integration#584: DataExtractor unit tests DataExtractor unit tests coverage Nov 30, 2019
@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-6372 has been created to process this Pull Request
✳️ @sivaschenko, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@sivaschenko sivaschenko added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Nov 30, 2019
@magento-engcom-team magento-engcom-team merged commit 50805d4 into magento:2.3-develop Dec 3, 2019
@m2-assistant
Copy link

m2-assistant bot commented Dec 3, 2019

Hi @kmlfadeless, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.5 milestone Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants