Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replaced deprecated addWarning method with addWarningMessage method … #28264

Merged
merged 2 commits into from
Jun 13, 2020
Merged

replaced deprecated addWarning method with addWarningMessage method … #28264

merged 2 commits into from
Jun 13, 2020

Conversation

kishorekumarkesavan
Copy link
Contributor

@kishorekumarkesavan kishorekumarkesavan commented May 18, 2020 •
edited by ghost
Loading

…in Security module

Replace deprecated addWarning method with addWarningMessage method in Magento core security module

Description (*)

  addWarning method is deprecated, to replace the addWarning method with addWarningMessage method in Magento core security module

Manual testing scenarios (*)

  1. Logged in to your magento admin panel , go to Store -> Configuration -> Advanced -> Admin -> Security -> Admin Account Sharing -> NO
  2. Logged in to your magento admin panel in a different browsers, in the current browser admin session will be created with the warning message.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] replaced deprecated addWarning method with addWarningMessage method … #28308: replaced deprecated addWarning method with addWarningMessage method …

@m2-assistant
Copy link

m2-assistant bot commented May 18, 2020

Hi @kishorekumarkesavan. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered only manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s). <test-build(s)> is a comma-separated list of build names. Allowed build names are Database Compare, Functional Tests CE, Functional Tests EE, Functional Tests B2B, Integration Tests, Magento Health Index, Sample Data Tests CE, Sample Data Tests EE, Sample Data Tests B2B, Static Tests, Unit Tests, WebAPI Tests.

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

@aleron75 aleron75 self-assigned this May 19, 2020
@aleron75
Copy link
Contributor

@magento run Unit Tests

@aleron75 aleron75 added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Cleanup labels May 19, 2020
@magento-engcom-team
Copy link
Contributor

Hi @aleron75, thank you for the review.
ENGCOM-7565 has been created to process this Pull Request

@engcom-Alfa engcom-Alfa self-assigned this May 19, 2020
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

After:
Screenshot from 2020-05-19 11-44-34

@engcom-Charlie engcom-Charlie self-assigned this May 19, 2020
@engcom-Charlie
Copy link
Contributor

@magento run all tests

@engcom-Charlie
Copy link
Contributor

@magento run all tests

@engcom-Charlie engcom-Charlie requested a review from aleron75 May 19, 2020 10:50
aleron75
aleron75 approved these changes May 20, 2020
View reviewed changes
Copy link
Contributor

@aleron75 aleron75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that the failing functional tests are flaky, so for me this PR can be approved.

@magento-engcom-team
Copy link
Contributor

Hi @aleron75, thank you for the review.
ENGCOM-7565 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@engcom-Charlie
Copy link
Contributor

Failed functional test not related to changes from this PR.

@engcom-Charlie engcom-Charlie added the QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) label May 20, 2020
@slavvka slavvka added Priority: P3 May be fixed according to the position in the backlog. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels May 20, 2020
@slavvka slavvka added this to the 2.4.1 milestone May 20, 2020
@slavvka
Copy link
Member

slavvka commented May 20, 2020

@magento create issue

@ghost ghost mentioned this pull request May 20, 2020
Closed
4 tasks
@engcom-Alfa engcom-Alfa added QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope and removed QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) labels Jun 12, 2020
magento-engcom-team pushed a commit that referenced this pull request Jun 13, 2020
@slavvka
ENGCOM-7565: replaced deprecated addWarning method with addWarningMes…
541c955 
…sage method … #28264
@magento-engcom-team magento-engcom-team merged commit b97490c into magento:2.4-develop Jun 13, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jun 13, 2020

Hi @kishorekumarkesavan, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleron75 aleron75 aleron75 approved these changes

Assignees

@aleron75 aleron75

@engcom-Alfa engcom-Alfa

@engcom-Charlie engcom-Charlie

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Cleanup Component: Security Partner: Ziffity partners-contribution Pull Request is created by Magento Partner Priority: P3 May be fixed according to the position in the backlog. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
Pull Requests Dashboard
Archived in project
Milestone
2.4.1
Development

Successfully merging this pull request may close these issues.

[Issue] replaced deprecated addWarning method with addWarningMessage method …
6 participants
@kishorekumarkesavan @aleron75 @magento-engcom-team @engcom-Alfa @engcom-Charlie @slavvka