#7413 fix, downloadable in group not working

[alekszakatov]

Description (*)

Fix for #7413
not sure why it was closed issue still reproducible in 2.4-develop

Fixed Issues (if relevant)

1. #7413

Manual testing scenarios (*)

1. create 1-3 downloadable products with real files for download
2. create group product and assign previously create product to current group product
3. (optional) set in configuration Catalog->Downloadable product options - Order Item Status to Enable Downloads - PENDING and allow Disable Guest Checkout if Cart Contains Downloadable Items - NO
4. complete checkout with group product, links should be available in email and in admin, if it will be registered customer link should be available in download section

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @alekszakatov. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

[alekszakatov]

@magento run all tests

[VladimirZaets]

Hi @alekszakatov. Thanks for collaboration. This PR was reviewed on Community Contribution Triage meeting. The recording of the meeting you can look by the link

[gabrieldagama]

Hi, @alekszakatov thanks for the pull request, it looks good! All our changes now must be covered with tests, are you able to cover this one?

Please let me know if you are available for it. Thanks.

[gabrieldagama]

The risk was set tolow due to: the suggested changes shouldn't affect other areas.

[gabrieldagama]

Hi @alekszakatov, looking at the SaveDownloadableOrderItemObserver, it seems we already have a solution for this issue:

$productType = $orderItem->getRealProductType() ?: $orderItem->getProductType();

I will close this PR for now, please feel free to reopen it if you think it's still necessary.
Thanks.

[m2-assistant]

Hi @alekszakatov, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.